Create test reports folder if it doesn't exist#173
Merged
mtojek merged 2 commits intoelastic:masterfrom Nov 16, 2020
Merged
Conversation
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
mtojek
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #172.
In #172 we only create the test reports folder if
elastic-package testis invoked. That is, the test reports folder was not being created ifelastic-package test pipelineorelastic-package test systemwas invoked.Initially I tried to fix this problem by creating the test reports folder for all possible invocations of
elastic-package test, including it's subcommands. However, this led to another problem: ifelastic-package test systemwas run followed byelastic-package test pipeline(or vice versa), the test results from the first subcommand invocation were being cleaned out by the second subcommand invocation.So finally I decided that we should simply not clean out the test reports folder at all when
elastic-package testor any of its subcommands are run. Instead, a user can useelastic-package clean(when we implement it) to clean out the test reports folder as needed.