[Windows enhancement ]Added processor field for service data stream in windows package#3618
Merged
ManojS-shetty merged 5 commits intoelastic:mainfrom Jul 12, 2022
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
belimawr
approved these changes
Jun 30, 2022
Contributor
belimawr
left a comment
There was a problem hiding this comment.
I'm not an integrations expert, but LGTM.
Contributor
|
@ManojS-shetty I've just realised this PR is still a draft. Is there anything missing or can it be promoted to a normal PR? |
Contributor
Author
Yes promoted to normal PR. Thank you:) |
efd6
reviewed
Jul 3, 2022
efd6
approved these changes
Jul 4, 2022
ishleenk17
reviewed
Jul 4, 2022
packages/windows/data_stream/service/agent/stream/stream.yml.hbs
Outdated
Show resolved
Hide resolved
efd6
reviewed
Jul 4, 2022
packages/windows/data_stream/service/agent/stream/stream.yml.hbs
Outdated
Show resolved
Hide resolved
ishleenk17
approved these changes
Jul 12, 2022
faec
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the processors for the windows integration UI for windows service data stream, So that users can provide the processors input from the UI and filter out the services based on service display name or service state.
Checklist
changelog.ymlfile.How to test this PR locally
elastic-packagecommandsRelated issues