Update CloudTrail - First draft of AWS integration edits by ellis-elastic · Pull Request #3611 · elastic/integrations

ellis-elastic · 2022-06-28T10:31:05Z

What does this PR do?

Added new content based on the new documentation guidelines.

In #3308 we updated docs for two AWS integrations to align with the new documentation guidelines and establish the relationship between the AWS integration/package ("AWS") and integrations for individual AWS services (for example, "AWS CloudFront").

Now we should update the docs for all AWS integrations for individual services to follow the same format as the updated "AWS CloudFront" integration docs.

This PR adds more context the AWS integration including:

Adds context to the "Overview" including a link to the relevant AWS page and an example
Lists the types of "Data streams" for the service
"Requirements" points back to "AWS" for detailed information on credentials and permissions
"Requirements" includes any other service-specific requirements
"Setup" establishes a relationship between the AWS integration/package ("AWS") and this integration
Includes "Reference" sections

For the reviewer

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Review by docs team
Review by integrations team

Related issues

Update integration docs for individual AWS/Amazon services #3572

Added new content based on the new documentation guidelines.

Changed Cloudtrail to CloudTrail

elasticmachine · 2022-06-28T10:43:06Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-07-01T08:37:56.802+0000
Duration: 10 min 32 sec

Steps errors

Expand to view the steps failures

`Check integration: aws`

Took 0 min 3 sec . View more details here
Description: ../../build/elastic-package check -v

`Google Storage Download`

Took 0 min 0 sec . View more details here

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2022-06-28T11:20:11Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`11/11`)	💚
Files	91.667% (`11/12`)	❕
Classes	91.667% (`11/12`)	❕
Methods	82.692% (`172/208`)	❕
Lines	92.673% (`2087/2252`)	❕
Conditionals	100.0% (`0/0`)	💚

ellis-elastic · 2022-06-29T12:10:18Z

Does CloudTrail log file integrity validation need to be turned on? Is that a requirement?

colleenmcginnis

Some minor suggestions below.

packages/aws/_dev/build/docs/cloudtrail.md

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

Updated note section in light on Coleen's comments

packages/aws/_dev/build/docs/cloudtrail.md

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

…trail-docs # Conflicts: # packages/aws/changelog.yml # packages/aws/manifest.yml

elasticmachine · 2022-07-29T18:24:14Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-07-29T18:12:18.182+0000
Duration: 11 min 26 sec

Steps errors

Expand to view the steps failures

`Check integration: aws`

Took 0 min 3 sec . View more details here
Description: ../../build/elastic-package check -v

`Google Storage Download`

Took 0 min 0 sec . View more details here

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

* Update Readme - First draft of AWS integration edits (#3834) Added new content based on the new documentation guidelines * Update WAF - First draft of AWS integration edits (#3833) Added new content based on the new documentation guidelines. * Update VPN.MD First draft of AWS integration edits (#3828) * Update VPN.MD First draft of AWS integration edits Added new content based on the new documentation guidelines. * fixed typo Removed space and duplicated for example * Update vpcflow,md First draft of AWS integration edits (#3826) Added new content based on the new documentation guidelines. * Update AWS Usage - First draft of AWS integration edits (#3824) * Update AWS Usage - First draft of AWS integration edits Added new content based on the new documentation guidelines. * Fixed typo removed a space * Update AWS transit gateway - first draft of AWS integration edits (#3810) added new content based on the new documentation guidelines. * Update SQS First draft of AWS integration edits (#3809) Added new content based on the new documentation guidelines. * Update SNS - First draft of AWS integration edits (#3808) * Update S3 storage lens- First draft of AWS integration edits (#3806) * update S3 - first draft of AWS integration edits (#3804) Added new content based on the new doc guidelines * Update Route 53 - First draft of AWS integration edits (#3756) * update Route 53 - first draft of AWS integration edits Added new content based on the new documentation guidelines * Fixed typo Added missing full stop * Update RDS - first draft of AWS integration edits (#3752) Added new content based on the new documentation guidelines * Update Nat gateway - first draft of AWS integration edits (#3751) Added new content based on the new documentation guidelines * Update Lambda - first draft of AWS integration edits (#3749) * update Lambda - first draft of AWS integration edits Added new content based on the new documentation guidelines * Fix typos in Lambda.md * Update Network Firewall - added new content based on the new doc guidelines (#3732) * Update Network Firewall - added new content based on the new documentation guidelines. * Update Manifest and Changelog * Ran build * revert cl/mani Co-authored-by: bmorelli25 <brandon.morelli@elastic.co> * Update ELB - first draft of AWS integration edits (#3656) * Update ELB - first draft of AWS integration edits Added new content based on the new documentation guidelines. * update changelog and manifest * update elb ran build * revert cl/mani Co-authored-by: bmorelli25 <brandon.morelli@elastic.co> * Update EC2 - first draft of AWS integration edits (#3638) * Update EC2 - first draft of AWS integration edits Added new content based on the new documentation guidelines. * Update Changelog and Manifest * update ec2.md ran build * Update packages/aws/_dev/build/docs/ec2.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ec2.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ec2.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ec2.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ec2.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * revert cl/mani Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> Co-authored-by: bmorelli25 <brandon.morelli@elastic.co> * Update EBS- first draft of AWS integration edits (#3634) * Update EBS- first draft of AWS integration edits Added new content based on the new documentation guidelines. * Update Changelog and Manifest * Ran elastic-pacakge build * Update packages/aws/_dev/build/docs/ebs.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ebs.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ebs.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ebs.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ebs.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ebs.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/ebs.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * revert cl/mani Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> Co-authored-by: bmorelli25 <brandon.morelli@elastic.co> * Update DynamoDB- first draft of AWS integration edits (#3633) * Update Dynamodb - first draft of aws integration edits Added new content based on the new documentation guidelines. * Update Changelog and Manifest * Ran build, updated changelog and manifest * Update packages/aws/_dev/build/docs/dynamodb.md Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Update dynamoDB Re worded the example para in light of reviewers comments * Ran elastic package build * revert cl/mani Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> Co-authored-by: bmorelli25 <brandon.morelli@elastic.co> * Update CloudTrail - First draft of AWS integration edits (#3611) * Update CloudTrail - first draft of aws integration edits Added new content based on the new documentation guidelines. * Update CouldTrail - fixed typo Changed Cloudtrail to CloudTrail * Update Changelog and manifest * Ran Build * Update packages/aws/_dev/build/docs/cloudtrail.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/cloudtrail.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/cloudtrail.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/cloudtrail.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Updated note section Updated note section in light on Coleen's comments * Re ran build * Update packages/aws/_dev/build/docs/cloudtrail.md Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Update packages/aws/_dev/build/docs/cloudtrail.md Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Update packages/aws/_dev/build/docs/cloudtrail.md Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * revert cl/mani Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> Co-authored-by: bmorelli25 <brandon.morelli@elastic.co> * Update Billing.md (#3584) * update Billing.md added new content based on the new documentation guidelines. * Update Changelog, manifest and ran build * Revert "Update Changelog, manifest and ran build" This reverts commit c0fda79. * Update changelog and manifest * Update Billing.md * Update packages/aws/_dev/build/docs/billing.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/billing.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Revert "Update Billing.md" This reverts commit 3868827. * Update packages/aws/_dev/build/docs/billing.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/billing.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/billing.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * Update packages/aws/_dev/build/docs/billing.md Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * update billing added details on the metrics collected * update billing ran build * fix changelog formatting * Update packages/aws/_dev/build/docs/billing.md Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Update packages/aws/docs/billing.md Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * Update Billing.md Removed overview heading * Update changelog and ran build * Update Billing Fixed duplicated word * revert cl/mani Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> Co-authored-by: bmorelli25 <brandon.morelli@elastic.co> * get it passing ci * update docs * Revert "Update Readme - First draft of AWS integration edits (#3834)" This reverts commit 76eaca3. * Update packages/aws/_dev/build/docs/natgateway.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * Update packages/aws/_dev/build/docs/vpcflow.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * Update packages/aws/_dev/build/docs/vpcflow.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * Update packages/aws/_dev/build/docs/waf.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * Update packages/aws/_dev/build/docs/vpcflow.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * Update packages/aws/_dev/build/docs/s3.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * Update packages/aws/_dev/build/docs/rds.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * Update packages/aws/_dev/build/docs/elb.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * Apply suggestions from code review * Update packages/aws/_dev/build/docs/ebs.md * Update packages/aws/_dev/build/docs/ec2.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * feedback * feedback * Apply suggestions from code review Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * feedback * `elastic-package build` * Update packages/aws/docs/ebs.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co> * `elastic-package build` * docs: address feedback * `elastic-package build` * address more feedback * more feedback * address feedback Co-authored-by: Ellis Pratt <103435263+ellis-elastic@users.noreply.github.com> Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>

Update CloudTrail - first draft of aws integration edits

ed9069c

Added new content based on the new documentation guidelines.

ellis-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Team:Docs Label for the Observability docs team labels Jun 28, 2022

ellis-elastic requested a review from a team as a code owner June 28, 2022 10:31

ellis-elastic assigned bmorelli25 Jun 28, 2022

ellis-elastic added 3 commits June 28, 2022 11:33

Update CouldTrail - fixed typo

4615fb2

Changed Cloudtrail to CloudTrail

Update Changelog and manifest

5e99fdb

Ran Build

7e30ca8

ellis-elastic mentioned this pull request Jun 28, 2022

Update integration docs for individual AWS/Amazon services #3572

Closed

24 tasks

colleenmcginnis requested a review from a team June 28, 2022 17:53

colleenmcginnis assigned colleenmcginnis and unassigned bmorelli25 Jun 28, 2022

colleenmcginnis reviewed Jun 29, 2022

View reviewed changes

ellis-elastic and others added 7 commits June 30, 2022 07:55

Update packages/aws/_dev/build/docs/cloudtrail.md

f064222

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

Update packages/aws/_dev/build/docs/cloudtrail.md

a4f51b9

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

Update packages/aws/_dev/build/docs/cloudtrail.md

5262a4c

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

Update packages/aws/_dev/build/docs/cloudtrail.md

e6e7b3e

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

Updated note section

d43634e

Updated note section in light on Coleen's comments

Re ran build

4898381

Merge branch 'main' into AWS-Cloudtrail-docs

e1b052e

bmorelli25 reviewed Jun 30, 2022

View reviewed changes

packages/aws/_dev/build/docs/cloudtrail.md Outdated Show resolved Hide resolved

bmorelli25 reviewed Jun 30, 2022

View reviewed changes

packages/aws/_dev/build/docs/cloudtrail.md Outdated Show resolved Hide resolved

bmorelli25 reviewed Jun 30, 2022

View reviewed changes

packages/aws/_dev/build/docs/cloudtrail.md Outdated Show resolved Hide resolved

bmorelli25 marked this pull request as draft June 30, 2022 19:12

ellis-elastic and others added 2 commits July 1, 2022 09:35

Update packages/aws/_dev/build/docs/cloudtrail.md

e634836

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

Update packages/aws/_dev/build/docs/cloudtrail.md

234723a

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

Update packages/aws/_dev/build/docs/cloudtrail.md

7ca838c

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

bmorelli25 changed the base branch from main to aws-doc-updates July 29, 2022 18:02

bmorelli25 added 2 commits July 29, 2022 11:10

revert cl/mani

e498f1c

Merge branch 'main' of github.com:elastic/integrations into AWS-Cloud…

16384a3

…trail-docs # Conflicts: # packages/aws/changelog.yml # packages/aws/manifest.yml

bmorelli25 marked this pull request as ready for review July 29, 2022 18:14

bmorelli25 merged commit d5c07d9 into elastic:aws-doc-updates Jul 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CloudTrail - First draft of AWS integration edits#3611

Update CloudTrail - First draft of AWS integration edits#3611
bmorelli25 merged 16 commits intoelastic:aws-doc-updatesfrom
ellis-elastic:AWS-Cloudtrail-docs

ellis-elastic commented Jun 28, 2022 •

edited

Loading

Uh oh!

elasticmachine commented Jun 28, 2022 •

edited

Loading

Build stats

`Check integration: aws`

`Google Storage Download`

Uh oh!

elasticmachine commented Jun 28, 2022 •

edited

Loading

Uh oh!

ellis-elastic commented Jun 29, 2022

Uh oh!

colleenmcginnis left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Jul 29, 2022

Build stats

`Check integration: aws`

`Google Storage Download`

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ellis-elastic commented Jun 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

For the reviewer

Checklist

Author's Checklist

Related issues

Uh oh!

elasticmachine commented Jun 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Build stats

Steps errors

Check integration: aws

Google Storage Download

🤖 GitHub comments

Uh oh!

elasticmachine commented Jun 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

ellis-elastic commented Jun 29, 2022

Uh oh!

colleenmcginnis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Jul 29, 2022

💔 Build Failed

Build stats

Steps errors

Check integration: aws

Google Storage Download

🤖 GitHub comments

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ellis-elastic commented Jun 28, 2022 •

edited

Loading

elasticmachine commented Jun 28, 2022 •

edited

Loading

`Check integration: aws`

`Google Storage Download`

elasticmachine commented Jun 28, 2022 •

edited

Loading

`Check integration: aws`

`Google Storage Download`