[cylance] Format host.mac per ECS#3368
Merged
andrewkroh merged 2 commits intoelastic:mainfrom May 18, 2022
andrewkroh:cylance/format-host-mac
Merged
[cylance] Format host.mac per ECS#3368andrewkroh merged 2 commits intoelastic:mainfrom andrewkroh:cylance/format-host-mac
andrewkroh merged 2 commits intoelastic:mainfrom
andrewkroh:cylance/format-host-mac
Conversation
Format host.mac as per ECS. It needed to be uppercased, dash separated, and converted to an array.
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
4 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
efd6
approved these changes
May 17, 2022
| "alias_host": [ | ||
| "ntium4450.www5.localdomain" | ||
| ], | ||
| "eth_host": "01:00:5e:ee:e8:77" |
Contributor
There was a problem hiding this comment.
Should this be changed as well?
Member
Author
There was a problem hiding this comment.
That's a good point. It would probably be best to change this rsa.eth_host field and all other MACs in the rsa.* namespace at once so the format is consistent for that field.
I opened adriansr/nwdevice2filebeat#21 which would make the changes I did for the ECS fields obsolete, but I expect we'll replace all of the rsa2elk integrations before we modify the generator and update all of the generated integrations again.
This was referenced May 22, 2022
andrewkroh
added a commit
that referenced
this pull request
Jun 28, 2022
This updates the ECS version used in all non-deprecated packages owned by elastic/security-external-integrations. These packages required fixes in order to comply with the `pattern` added to ECS to validate MAC addresses. - cef - #3566 - crowdstrike - #3302 - cylance.protect - #3368 - fortinet.fortimanager - #3401 - iptables.log - #3358 - microsoft_dhcp - #3300 - pfsense - #3303 - snort - #3301 - sonicwall.firewall - #3360 - sophos.utm - #3370 NOTE: The following packages were not updated for 8.2.0. I didn't catch anything in 8.1 or 8.2 that needed changed. - auth0 - 1.12.0 - carbon_black_cloud - 8.0.0 - cisco_ise - 8.0.0 - cisco_meraki - 8.0.0 - hid_bravura_monitor - 1.12.0 - modsecurity - 1.12.0 - mysql_enterprise - 8.0.0 - netskope - 8.0.0 - oracle - 8.0.0 - symantec_endpoint - 1.12.0 - ti_recordedfuture - 8.0 [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@6efa1ecb3871 \ --ecs-version=8.3.0 \ -ecs-git-ref=v8.3.0 \ --pr=3353 \ --owner=elastic/security-external-integrations \ packages/*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Format the
host.macfield as per ECS (https://www.elastic.co/guide/en/ecs/current/ecs-client.html#field-client-mac).The value also needed to be converted to an array.
Checklist
changelog.ymlfile.