@claude how does this compare to the other feedback given to other input package PRs? as well as what has merged into main? any important discrepancies? It looks like some of the ways we're configuring collection are no longer available and use the metrics syntax: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/dockerstatsreceiver/README.md

Can you review the input package for other discrepancies?

Vale Linting Results

Summary: 6 suggestions found

The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

Claude finished @strawgate's task in 2m 52s —— View job

Reviewing Docker OTel Input Package

• Gather repository context and understand input package patterns
• Review other input package PRs and what merged into main
• Fetch current OpenTelemetry dockerstatsreceiver documentation
• Compare this PR's configuration with upstream OTel docs
• Identify discrepancies and provide feedback

Summary

I've compared this PR against merged OTel input packages (hostmetrics_input_otel, nginx_input_otel, kubeletstats_input_otel, iis_input_otel) and the upstream dockerstatsreceiver documentation. Here are my findings:

⚠️ Key Discrepancies

1. Missing metrics Configuration Field

This is the issue you mentioned. The upstream receiver supports a metrics configuration block to enable/disable individual metrics:

receivers:
  docker_stats:
    metrics:
      container.cpu.usage.percpu:
        enabled: true
      container.memory.active_anon:
        enabled: true

The kubeletstats_input_otel package (merged recently) handles this with a type: yaml field for metrics:

# kubeletstats_input_otel pattern:
- name: metrics
  type: yaml
  title: Metrics Configuration
  description: |
    ## Example configuration for enabling optional metrics.
    # k8s.container.cpu.node.utilization:
    #   enabled: true

Recommendation: Add a metrics yaml field to allow users to enable optional metrics like container.cpu.usage.percpu, container.memory.active_anon, etc.

2. provide_per_core_cpu_metrics is Deprecated

The provide_per_core_cpu_metrics option is no longer documented in the upstream receiver. It has been replaced by the metrics syntax:

metrics:
  container.cpu.usage.percpu:
    enabled: true

Recommendation: Remove provide_per_core_cpu_metrics and use the metrics yaml field instead.

3. Missing initial_delay Field

The upstream receiver supports initial_delay (default: 1s), which is present in other OTel input packages (nginx_input_otel, iis_input_otel, kubeletstats_input_otel).

Recommendation: Add initial_delay field for consistency with other packages.

4. type: text vs type: duration for Interval Fields

Other merged packages use type: duration for time-based fields:

• nginx_input_otel: type: duration for collection_interval and initial_delay
• iis_input_otel: type: duration for collection_interval and initial_delay
• kubeletstats_input_otel: type: duration for collection_interval and initial_delay

This PR uses type: text for period.

Recommendation: Use type: duration for period (or rename to collection_interval for consistency with upstream naming).

5. Missing source.license Field

Other merged OTel input packages include:

source:
  license: "Elastic-2.0"

This is missing from this package's manifest.

📋 Comparison Table

📁 Missing Package Structure Elements

Based on other merged packages, consider adding:

1. _dev/build/build.yml - Build configuration (present in prometheus_input, sql_input, etc.)
2. System tests - More comprehensive test policies (see kubeletstats_input_otel pattern with multiple test configs)

✅ What's Done Well

• Good documentation in docs/README.md
• Core configuration options are covered
• Package structure follows the basic pattern
• Uses otelcol input type correctly
• Includes resourcedetection processor in the pipeline

Recommended Changes

1. Add metrics yaml field to enable/disable specific metrics
2. Remove provide_per_core_cpu_metrics (deprecated upstream)
3. Add initial_delay field for consistency
4. Change type: text to type: duration for time-based fields
5. Add source.license: "Elastic-2.0" to manifest
6. Consider renaming period to collection_interval to match upstream naming

--- |

Why is Claude responding? | Type @claude to interact further

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@claude Review the PR for any discrepancies, any existing comments, compare against existing packages and make a TODO list with all the action items.

@claude let's do one final review. We have two PRs up for packages like this #17396 and #17397 are we already following the recommendations in those guides?

Claude finished @strawgate's task in 1m 25s —— View job

Final Review: Comparing Against Guide PRs

• Fetch PR docs: Add guide for creating OTel Input Packages #17396 (Contributing OTel Input Packages guide)
• Fetch PR Update CONTRIBUTING.md to mention creating a PR #17397 (OTel Input Package Reference guide)
• Review current package against contributing guidelines
• Review current package against reference specifications
• Create comprehensive checklist of compliance status

Compliance Summary

I've compared this package against the guidelines in PR #17396 (OTel Input Packages Guide) and PR #17397 (CONTRIBUTING.md updates).

✅ Submission Checklist from Guide (PR #17396)

✅ Variable Types (from Guide)

✅ Template Development (from Guide)

✅ Documentation (from Guide)

✅ PR Submission Requirements (from PR #17397)

Result: ✅ Package Fully Complies with Guidelines

This package follows all the recommendations from both guide PRs:

1. Package structure matches the documented structure exactly
2. Manifest configuration uses correct types (type: input, input: otelcol, categories, conditions)
3. Variable definitions follow best practices (duration for time, yaml for complex config, multi: true for lists)
4. Template patterns correctly use Handlebars conditionals and iteration
5. Documentation is comprehensive and links to upstream OTel docs
6. Testing includes both policy tests (with .expected files) and system tests
7. CODEOWNERS and changelog are properly configured

The package is ready for merge from a guidelines compliance perspective.

--- | Branch: docker_otel_input

Why is Claude responding? | Type @claude to interact further

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

💚 Build Succeeded

• Buildkite Build
• Commit: 1e4887b

History

• 💚 Build #38094 succeeded db7dc7e
• 💚 Build #38085 succeeded a81d6cd
• 💚 Build #38002 succeeded 2c7d51c
• 💚 Build #37994 succeeded 0df9636
• 💔 Build #37991 failed ec64347

Package docker_input_otel - 0.1.0 containing this change is available at https://epr.elastic.co/package/docker_input_otel/0.1.0/