Remove duplicate security solution tags from AWS package#17022
Remove duplicate security solution tags from AWS package#17022teresaromero merged 10 commits intoelastic:mainfrom
Conversation
Packages affected: This PR removes duplicate security-solution-default tags from Kibana dashboards, searches, and visualizations, deletes corresponding tag definition files, and updates changelog entries and manifest versions. Changes: - Removed duplicate tag references from dashboards and searches - Deleted duplicate tag definition files - Added changelog entries (bugfix, patch version) - Updated package manifest versions Total files changed: 14
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
efd6
left a comment
There was a problem hiding this comment.
Confirming my understanding that the canonical location for tags will now be in packages/aws/kibana/tag/aws-security-solution-default.json. Is that correct?
…grations into fix-duplicate-tags-aws
When a tag is defined at |
There was a problem hiding this comment.
The PR correctly removes duplicate security-solution-default tag references from all affected dashboards and searches (9 dashboards, 3 searches), deletes the corresponding tag definition file, updates the changelog, and bumps the version. All files containing the duplicate tag are addressed, and the changes align with the validation requirements from package-spec PR #1042 and elastic-package PR #3163.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
The PR correctly removes duplicate security-solution-default tag references from the AWS package. The changes are valid because:
- The
kibana/tags.ymlfile already defines the Security Solution tag assignments, making the inline JSON references redundant - All modified JSON files maintain valid structure after the tag reference removal
- The changelog entry and version bump follow the repository conventions
elastic-package checkpasses without duplicate tag errors (SVR00007)
The PR aligns with the package-spec validation changes from elastic/package-spec#1042.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Thanks for the clarification. |
💚 Build Succeeded
History
|
|
Package aws - 6.1.1 containing this change is available at https://epr.elastic.co/package/aws/6.1.1/ |
* Remove duplicate security solution tags from AWS package Packages affected: This PR removes duplicate security-solution-default tags from Kibana dashboards, searches, and visualizations, deletes corresponding tag definition files, and updates changelog entries and manifest versions. Changes: - Removed duplicate tag references from dashboards and searches - Deleted duplicate tag definition files - Added changelog entries (bugfix, patch version) - Updated package manifest versions Total files changed: 14 * update changelog * Remove aws-security-solution-default tag to eliminate duplication * Update packages/aws/changelog.yml Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Proposed commit message
This PR removes duplicate security-solution-default tags from Kibana dashboards, searches, and visualizations, deletes corresponding tag definition files, and updates changelog entries and manifest versions.
Changes:
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots