Skip to content

[system] stop starting unnecessary log input on Windows#16337

Merged
leehinman merged 1 commit intoelastic:mainfrom
leehinman:16236_system_windows_fix
Feb 12, 2026
Merged

[system] stop starting unnecessary log input on Windows#16337
leehinman merged 1 commit intoelastic:mainfrom
leehinman:16236_system_windows_fix

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Dec 5, 2025

Proposed commit message

Stop starting unnecessary log input on Windows.

This is done by changing the conditional around the log input &
journald inputs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

  1. Install on Windows
  2. Should only be 2 agentbeats running for the system integration

Related issues

Screenshots

@leehinman leehinman force-pushed the 16236_system_windows_fix branch from 08dc8a3 to 5bf075c Compare December 5, 2025 22:16
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 5, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@leehinman leehinman marked this pull request as ready for review December 9, 2025 01:56
@leehinman leehinman requested review from a team as code owners December 9, 2025 01:56
@lalit-satapathy lalit-satapathy requested a review from shmsr December 9, 2025 10:02
@lalit-satapathy
Copy link
Copy Markdown
Contributor

lalit-satapathy commented Dec 9, 2025

Added @shmsr for code owner approval.

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Dec 9, 2025
@botelastic
Copy link
Copy Markdown

botelastic bot commented Feb 5, 2026

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Feb 5, 2026
@botelastic botelastic bot removed the Stalled label Feb 10, 2026
@leehinman leehinman force-pushed the 16236_system_windows_fix branch from 5bf075c to 46bb08f Compare February 11, 2026 20:51
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 11, 2026 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@leehinman leehinman force-pushed the 16236_system_windows_fix branch from 46bb08f to 0a8c2ca Compare February 11, 2026 23:51
@leehinman leehinman requested a review from a team as a code owner February 11, 2026 23:51
mrodm
mrodm approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the changes in codeowners tool 👍

@leehinman leehinman force-pushed the 16236_system_windows_fix branch from 0a8c2ca to 29628b0 Compare February 12, 2026 19:41
@leehinman leehinman enabled auto-merge (squash) February 12, 2026 19:41
@leehinman leehinman merged commit 7560433 into elastic:main Feb 12, 2026
9 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Feb 12, 2026

Package system - 2.12.3 containing this change is available at https://epr.elastic.co/package/system/2.12.3/

jakubgalecki0 pushed a commit to jakubgalecki0/integrations that referenced this pull request Feb 19, 2026
@leehinman @jakubgalecki0
stop starting unnecessary log input on Windows (elastic#16337)
73c9227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrodm mrodm mrodm approved these changes

@nfritts nfritts nfritts approved these changes

@stefans-elastic stefans-elastic stefans-elastic approved these changes

@shmsr shmsr Awaiting requested review from shmsr

Assignees

No one assigned

Labels

Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[system]: On Windows extra agentbeat is started

7 participants

@leehinman @lalit-satapathy @elasticmachine @mrodm @nfritts @stefans-elastic @andrewkroh