Skip to content

Update system tests commands to build elastic-agent containers#15863

Merged
mrodm merged 1 commit intoelastic:mainfrom
mrodm:fix_tests_update_packages_step
Nov 5, 2025
Merged

Update system tests commands to build elastic-agent containers#15863
mrodm merged 1 commit intoelastic:mainfrom
mrodm:fix_tests_update_packages_step

Conversation

@mrodm
Copy link
Collaborator

@mrodm mrodm commented Nov 4, 2025 •
edited
Loading

Proposed commit message

Update how system tests build the elastic-agent containers used in system tests.
Add parameter -y in the step in charge of updating packages to assume yes to all questions:

sh-5.1# microdnf update --help-all
Usage:
  microdnf [OPTION?] upgrade [PACKAGE?] - Upgrade packages

Help Options:
  -h, --help                    Show help options
  --help-all                    Show all help options
  --help-global                 Show global help options

Global Options:
  --assumeno                    Automatically answer no for all questions
  -y, --assumeyes               Automatically answer yes for all questions
...

Adding this parameter avoids being stuck the Buildkite steps waiting for confirmation as it happened in this build:

#8 2.499 Transaction Summary:
#8 2.499  Installing:        1 packages
#8 2.499  Reinstalling:      0 packages
#8 2.499  Upgrading:         8 packages
#8 2.499  Obsoleting:        0 packages
#8 2.499  Removing:          0 packages
#8 2.499  Downgrading:       0 packages
#8 2.499 Is this ok [y/N]:

This flag was already present in the system tests of the oracle package:

integrations/packages/oracle/data_stream/memory/_dev/test/system/test-memory-config.yml

Lines 13 to 16 in a8fcb8e

elif grep -q "Red Hat" /etc/os-release ; then
microdnf update -y
microdnf install -y libaio wget unzip
microdnf clean all

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

cd packages/system
elastic-package stack up -v -d --version 9.2.0
elastic-package test system -v --data-streams auth

@mrodm mrodm self-assigned this Nov 4, 2025
@mrodm mrodm changed the title Update system tests to assume yes when updating packages Update system tests commands to build elastic-agent containers Nov 4, 2025
@mrodm mrodm requested a review from a team November 4, 2025 19:51
@mrodm mrodm marked this pull request as ready for review November 4, 2025 19:51
@mrodm mrodm requested review from a team as code owners November 4, 2025 19:51
@mrodm mrodm requested review from belimawr and orestisfl November 4, 2025 19:51
@elasticmachine
Copy link

elasticmachine commented Nov 4, 2025

💚 Build Succeeded

cc @mrodm

@mrodm mrodm mentioned this pull request Nov 4, 2025
Closed
@andrewkroh andrewkroh added Integration:system System Integration:iptables Iptables Integration:journald Custom Journald logs Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] labels Nov 4, 2025
@elasticmachine
Copy link

elasticmachine commented Nov 4, 2025

Pinging @elastic/integration-experience (Team:Integration-Experience)

@elasticmachine
Copy link

elasticmachine commented Nov 4, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

elasticmachine commented Nov 4, 2025

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@mrodm mrodm merged commit 04c06af into elastic:main Nov 5, 2025
7 checks passed
@mrodm mrodm deleted the fix_tests_update_packages_step branch November 5, 2025 15:29
tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
@mrodm
Update system tests to assume yes when updating packages (elastic#15863)
17f868f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@qcorporation qcorporation qcorporation approved these changes

@teresaromero teresaromero teresaromero approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@orestisfl orestisfl Awaiting requested review from orestisfl orestisfl is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@mrodm mrodm

Labels

Integration:iptables Iptables Integration:journald Custom Journald logs Integration:system System Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mrodm @elasticmachine @jsoriano @pierrehilbert @qcorporation @teresaromero @andrewkroh