Skip to content

[O365] Add policy tests and benchmarks#15554

Merged
moxarth-rathod merged 7 commits intoelastic:mainfrom
moxarth-rathod:add-policy-tests-and-benchmarks
Oct 23, 2025
Merged

[O365] Add policy tests and benchmarks#15554
moxarth-rathod merged 7 commits intoelastic:mainfrom
moxarth-rathod:add-policy-tests-and-benchmarks

Conversation

@moxarth-rathod
Copy link
Contributor

@moxarth-rathod moxarth-rathod commented Oct 6, 2025

Proposed commit message

o365: add policy tests and benchmarks for integration quality checks

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/o365 directory.
  • Run the following command to run tests.

elastic-package test -v

Related issues

@moxarth-rathod moxarth-rathod self-assigned this Oct 6, 2025
@moxarth-rathod moxarth-rathod added enhancement New feature or request Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Oct 6, 2025
@moxarth-rathod moxarth-rathod marked this pull request as ready for review October 7, 2025 10:42
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner October 7, 2025 10:42
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@moxarth-rathod moxarth-rathod changed the title [O365] Add policy tests and benchmarks [O365] Add policy tests Oct 8, 2025
@moxarth-rathod moxarth-rathod changed the title [O365] Add policy tests [O365] Add policy tests and benchmarks Oct 8, 2025
- RequiredResourceAccess
- name: NewValue
enum:
- "[\r\n {\r\n \"ResourceAppId\": \"c5393580-f805-4401-95e8-94b7a6ef2fc2\",\r\n \"RequiredAppPermissions\": [\r\n {\r\n \"EntitlementId\": \"4807a72c-ad38-4250-94c9-4eabfe26cd55\",\r\n \"DirectAccessGrant\": true,\r\n \"ImpersonationAccessGrants\": []\r\n },\r\n {\r\n \"EntitlementId\": \"e2cea78f-e743-4d8f-a16a-75b629a038ae\",\r\n \"DirectAccessGrant\": true,\r\n \"ImpersonationAccessGrants\": []\r\n }\r\n ],\r\n \"EncodingVersion\": 1\r\n },\r\n {\r\n \"ResourceAppId\": \"00000003-0000-0000-c000-000000000000\",\r\n \"RequiredAppPermissions\": [\r\n {\r\n \"EntitlementId\": \"e1fe6dd8-ba31-4d61-89e7-88639da4683d\",\r\n \"DirectAccessGrant\": false,\r\n \"ImpersonationAccessGrants\": [\r\n 20\r\n ]\r\n }\r\n ],\r\n \"EncodingVersion\": 1\r\n }\r\n]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are line feeds required here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be so big?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required to be large, so I've updated the file and make it short.

@moxarth-rathod moxarth-rathod requested a review from efd6 October 15, 2025 09:51
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 15, 2025

🚀 Benchmarks report

Package o365 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2207.51 1562.5 -645.01 (-29.22%) 💔
audit 2207.51 2525.25 317.74 (14.39%) 👍

}
}
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final new line.

@moxarth-rathod moxarth-rathod requested a review from efd6 October 17, 2025 05:18
@kcreddy
Copy link
Contributor

kcreddy commented Oct 21, 2025

/test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moxarth-rathod

@moxarth-rathod moxarth-rathod merged commit f0b65ce into elastic:main Oct 23, 2025
7 checks passed
agithomas pushed a commit to agithomas/integrations that referenced this pull request Oct 30, 2025
o365: add policy tests and benchmarks for integration quality checks
tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
o365: add policy tests and benchmarks for integration quality checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:o365 Microsoft Office 365 Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

o365: Add policy tests for integration quality checks

4 participants