Skip to content

[AWS Health] Remove linked accounts option from config#14573

Merged
lucian-ioan merged 5 commits intoelastic:mainfrom
lucian-ioan:aws_health_disable_linked_accounts
Jul 18, 2025
Merged

[AWS Health] Remove linked accounts option from config#14573
lucian-ioan merged 5 commits intoelastic:mainfrom
lucian-ioan:aws_health_disable_linked_accounts

Conversation

@lucian-ioan
Copy link
Copy Markdown
Contributor

@lucian-ioan lucian-ioan commented Jul 17, 2025

Proposed commit message

Removes linked account option from config as it is not currently supported.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@lucian-ioan lucian-ioan self-assigned this Jul 17, 2025
@lucian-ioan lucian-ioan requested review from a team as code owners July 17, 2025 05:59
@lucian-ioan lucian-ioan added bug Something isn't working, use only for issues Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 17, 2025
@lucian-ioan lucian-ioan requested a review from agithomas July 17, 2025 05:59
@lucian-ioan lucian-ioan requested a review from gpop63 July 17, 2025 06:01
show_user: false
default: true
description: When include_linked_accounts is set to true, CloudWatch metrics will be collected from both linked accounts and the monitoring account. Default is true.
# - name: include_linked_accounts
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either add an appropriate comment on why it is commented out or remove this configuration.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think owning_account is also related to this linked account feature, and if we remove these variables from the manifest what about the agent config that references them?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @gpop63 . @lucian-ioan , kindly do an upgrade testing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, pushed the changes. I'm also upgrading the integration from a previous version to this one to check that all goes well.

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Jul 17, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@lucian-ioan
Copy link
Copy Markdown
Contributor Author

@agithomas Tested with integration update and everything works as expected.

Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elastic-sonarqube
Copy link
Copy Markdown

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @lucian-ioan

@lucian-ioan lucian-ioan merged commit a87ccff into elastic:main Jul 18, 2025
9 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package aws - 3.13.2 containing this change is available at https://epr.elastic.co/package/aws/3.13.2/

@andrewkroh andrewkroh added the bugfix Pull request that fixes a bug issue label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues bugfix Pull request that fixes a bug issue Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AWS Health] Add support for the linked account

5 participants