[aws] Ingest managed insights from Security Hub#14354
Merged
chrisberkhout merged 3 commits intoelastic:mainfrom Jul 1, 2025
Merged
[aws] Ingest managed insights from Security Hub#14354chrisberkhout merged 3 commits intoelastic:mainfrom
chrisberkhout merged 3 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
guardduty |
1061.57 | 887.31 | -174.26 (-16.42%) | 💔 |
inspector |
2012.07 | 1492.54 | -519.53 (-25.82%) | 💔 |
To see the full report comment with /test benchmark fullreport
efd6
reviewed
Jun 29, 2025
Contributor
efd6
left a comment
There was a problem hiding this comment.
In commit message, s/retieved/retrieved/.
Comment on lines
+81
to
+84
| # This transform's job is to fail and end pagination when finished. | ||
| # It will set a value if the last request was the first in the sequence | ||
| # (which collects the managed insights), or if there is another page of | ||
| # custom insights to fetch. |
Contributor
There was a problem hiding this comment.
There's enough HTTPJSON magic here that I think the comment needs to explain more about how it is actually working.
Contributor
Author
There was a problem hiding this comment.
I added a sentence. Here's the full new comment:
# This transform's job is to fail and end pagination when finished.
# It will set a value if the last request was the first in the sequence
# (which collects the managed insights), or if there is another page of
# custom insights to fetch. Otherwise, there will be a value template
# error (.last_response.body.NextToken doesn't exist) and the pagination
# sequence will end (because fail_on_template_error is set).
ea0efa3 to
0444f3e
Compare
|
💚 Build Succeeded
History
|
|
Package aws - 3.9.0 containing this change is available at https://epr.elastic.co/package/aws/3.9.0/ |
robester0403
pushed a commit
to robester0403/integrations
that referenced
this pull request
Jul 8, 2025
The AWS Security Hub API's GetInsights endpoint[1] returns only custom insights. Managed insights[2] are built-in, and can only be retrieved by ARN. Fetch a hard-coded list of managed insights first, then fetch pages of custom insights as before. This has been tested against the live API. [1]: https://docs.aws.amazon.com/securityhub/1.0/APIReference/API_GetInsights.html [2]: https://docs.aws.amazon.com/securityhub/latest/userguide/securityhub-managed-insights.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Related issues