Skip to content

buildkite: use GCP OIDC (backport #13856)#13874

Merged
v1v merged 2 commits intobackport-security_detection_engine-8.16from
mergify/bp/backport-security_detection_engine-8.16/pr-13856
May 19, 2025
Merged

buildkite: use GCP OIDC (backport #13856)#13874
v1v merged 2 commits intobackport-security_detection_engine-8.16from
mergify/bp/backport-security_detection_engine-8.16/pr-13856

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented May 11, 2025

Proposed commit message

  • Use GCP OIDC to copy the logs to the private storage.
  • Use gcloud instead of gsutil (so it honours the Env variables)
  • Tear-down is now managed by the BK plugin itself.

Test

See the ci build

image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Relates to elastic/elastic-package#2569

Screenshots

This is an automatic backport of pull request #13856 done by [Mergify](https://mergify.com).

@v1v @mergify
buildkite: use GCP OIDC (#13856)
be16a0c 
(cherry picked from commit 47b4432)

# Conflicts:
#	.buildkite/hooks/pre-command
#	.buildkite/pipeline.serverless.yml
#	.buildkite/scripts/trigger_integrations_in_parallel.sh
@mergify mergify bot requested a review from a team as a code owner May 11, 2025 08:00
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label May 11, 2025
@mergify
Copy link
Contributor Author

mergify bot commented May 11, 2025

Cherry-pick of 47b4432 has failed:

On branch mergify/bp/backport-security_detection_engine-8.16/pr-13856
Your branch is up to date with 'origin/backport-security_detection_engine-8.16'.

You are currently cherry-picking commit 47b443259.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .buildkite/hooks/pre-exit
	modified:   .buildkite/scripts/common.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/hooks/pre-command
	both modified:   .buildkite/pipeline.serverless.yml
	both modified:   .buildkite/scripts/trigger_integrations_in_parallel.sh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request May 11, 2025
Merged
5 tasks
@v1v v1v self-assigned this May 11, 2025
@v1v v1v closed this May 15, 2025
@v1v v1v reopened this May 16, 2025
@elasticmachine
Copy link

elasticmachine commented May 16, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @v1v

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented May 16, 2025

🚀 Benchmarks report

Package bluecoat 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
director 35714.29 22222.22 -13492.07 (-37.78%) 💔

Package fortinet_fortiedr 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1297.02 683.53 -613.49 (-47.3%) 💔

Package modsecurity 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
auditlog 693.96 442.87 -251.09 (-36.18%) 💔

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented May 16, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v v1v removed the conflicts There is a conflict in the backported pull request label May 16, 2025
@v1v v1v merged commit 4b505f0 into backport-security_detection_engine-8.16 May 19, 2025
5 of 6 checks passed
@v1v v1v deleted the mergify/bp/backport-security_detection_engine-8.16/pr-13856 branch May 19, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v1v v1v v1v approved these changes

@mrodm mrodm mrodm approved these changes

Assignees

@v1v v1v

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elasticmachine @v1v @mrodm