Skip to content

{system,windows} Remove dynamic template to avoid ECS overrides.#13044

Merged
marc-gr merged 2 commits intoelastic:mainfrom
marc-gr:fix/dynamic_templates
Mar 11, 2025
Merged

{system,windows} Remove dynamic template to avoid ECS overrides.#13044
marc-gr merged 2 commits intoelastic:mainfrom
marc-gr:fix/dynamic_templates

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Mar 10, 2025 •
edited
Loading

Proposed commit message

Remove dynamic template to avoid ECS overrides.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@marc-gr marc-gr added Integration:windows Windows Integration:system System bugfix Pull request that fixes a bug issue Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] labels Mar 10, 2025
@marc-gr marc-gr force-pushed the fix/dynamic_templates branch from 0cf4b51 to 14456da Compare March 10, 2025 16:28
@marc-gr marc-gr marked this pull request as ready for review March 10, 2025 16:28
@marc-gr marc-gr requested review from a team as code owners March 10, 2025 16:28
@marc-gr marc-gr requested review from faec and leehinman March 10, 2025 16:28
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 10, 2025

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@marc-gr
Copy link
Copy Markdown
Contributor Author

marc-gr commented Mar 10, 2025

/test

@marc-gr marc-gr force-pushed the fix/dynamic_templates branch from 14456da to 7aa4671 Compare March 10, 2025 16:43
@marc-gr marc-gr enabled auto-merge (squash) March 10, 2025 16:54
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Mar 10, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 10, 2025

💚 Build Succeeded

History

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Mar 10, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@marc-gr marc-gr changed the title {system,windows} Fix dynamic template for windows data streams {system,windows} Remove dynamic template to avoid ECS overrides. Mar 11, 2025
@marc-gr marc-gr mentioned this pull request Mar 11, 2025
Closed
@marc-gr marc-gr merged commit 3fb0320 into elastic:main Mar 11, 2025
7 checks passed
@marc-gr marc-gr deleted the fix/dynamic_templates branch March 11, 2025 09:42
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Mar 11, 2025

Package system - 1.67.3 containing this change is available at https://epr.elastic.co/package/system/1.67.3/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Mar 11, 2025

Package windows - 2.5.2 containing this change is available at https://epr.elastic.co/package/windows/2.5.2/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@marc-gr @flexitrev
Fix dynamic template for windows data streams (#13044)
ebf589d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@intxgo intxgo intxgo approved these changes

@leehinman leehinman leehinman approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

No one assigned

Labels

bugfix Pull request that fixes a bug issue Integration:system System Integration:windows Windows Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marc-gr @elasticmachine @intxgo @leehinman