cloudflare_logpush: expand set of supported fields and add data streams#12782
Merged
efd6 merged 11 commits intoelastic:mainfrom Apr 2, 2025
Merged
cloudflare_logpush: expand set of supported fields and add data streams#12782efd6 merged 11 commits intoelastic:mainfrom
efd6 merged 11 commits intoelastic:mainfrom
Conversation
e3ca826 to
7b5c0ea
Compare
🚀 Benchmarks reportTo see the full report comment with |
b4e8594 to
3700282
Compare
3700282 to
40b0641
Compare
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
40b0641 to
a92b51b
Compare
Contributor
chemamartinez
left a comment
There was a problem hiding this comment.
I think we still need to add some fields for the gateway_http data stream, the ones that are not linked in the table of the original issue.
Notice that the link to the documentation for the gateway_http data stream is pointing to the gateway_network dataset so that should be why you couldn't find them.
packages/cloudflare_logpush/data_stream/dlp_forensic_copies/agent/stream/aws-s3.yml.hbs
Outdated
Show resolved
Hide resolved
packages/cloudflare_logpush/data_stream/email_security_alerts/agent/stream/aws-s3.yml.hbs
Outdated
Show resolved
Hide resolved
...ges/cloudflare_logpush/data_stream/gateway_network/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
...ges/cloudflare_logpush/data_stream/gateway_network/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
...ges/cloudflare_logpush/data_stream/gateway_network/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
...ges/cloudflare_logpush/data_stream/gateway_network/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
...s/cloudflare_logpush/data_stream/network_analytics/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/cloudflare_logpush/data_stream/page_shield_events/agent/stream/aws-s3.yml.hbs
Outdated
Show resolved
Hide resolved
7a1c24e to
546acaf
Compare
Contributor
Author
|
@chemamartinez I marked the missing (now corrected) fields in the table in the issue with a |
chemamartinez
approved these changes
Mar 14, 2025
Contributor
chemamartinez
left a comment
There was a problem hiding this comment.
One comment left. Apart from that, it looks good!
packages/cloudflare_logpush/data_stream/dlp_forensic_copies/manifest.yml
Outdated
Show resolved
Hide resolved
kcreddy
reviewed
Mar 14, 2025
packages/entityanalytics_ad/data_stream/user/_dev/test/pipeline/test-user.json-expected.json
Show resolved
Hide resolved
packages/cloudflare_logpush/data_stream/page_shield_events/agent/stream/http_endpoint.yml.hbs
Outdated
Show resolved
Hide resolved
...eam/page_shield_events/_dev/test/pipeline/test-pipeline-page-shield-events.log-expected.json
Show resolved
Hide resolved
...m/dlp_forensic_copies/_dev/test/pipeline/test-pipeline-dlp-forensic-copies.log-expected.json
Show resolved
Hide resolved
33 tasks
kcreddy
approved these changes
Mar 17, 2025
chemamartinez
approved these changes
Mar 17, 2025
7928300 to
cce278d
Compare
cce278d to
35543da
Compare
New data streams: * page_shield_events * dlp_forensic_copies * email_security_alerts Tests for new data streams were hand crafted from the API documentation.
35543da to
9cf3521
Compare
|
💚 Build Succeeded
History
cc @efd6 |
|
Package cloudflare_logpush - 1.36.0 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.36.0/ |
flexitrev
pushed a commit
that referenced
this pull request
Apr 3, 2025
…ms (#12782) New data streams: * page_shield_events * dlp_forensic_copies * email_security_alerts Tests for new data streams were hand crafted from the API documentation.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Warning
No test cases are available for the new fields and tests for the new data streams are constructed from documentation without any ground truth.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots