Skip to content

Add pull request template#123

Merged
mtojek merged 4 commits intoelastic:masterfrom
mtojek:pr_template
Jun 30, 2020
Merged

Add pull request template#123
mtojek merged 4 commits intoelastic:masterfrom
mtojek:pr_template

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Jun 29, 2020

This PR setups a pull-request template for the repository.

Preview link: https://github.com/mtojek/integrations/blob/pr_template/.github/PULL_REQUEST_TEMPLATE.md

@mtojek mtojek added the Team:Integrations Label for the Integrations team label Jun 29, 2020
@mtojek mtojek requested a review from ycombinator June 29, 2020 08:53
@mtojek mtojek self-assigned this Jun 29, 2020
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #123 updated]

  • Start Time: 2020-06-30T14:12:03.845+0000

  • Duration: 3 min 33 sec

- Closes #123
- Relates #123
- Requires #123
- Superseds #123
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: supersedes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, my bad, sorry.

## Author's Checklist

<!-- Recommended
Add a checklist of things that are required to be reviewed in order to have the PR approved
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as the line under Checklist. I think this line here is good but the one under Checklist can be removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@mtojek mtojek requested a review from ycombinator June 30, 2020 14:00

## Checklist

- [ ] I have reviewed [tips for building integrations](https://github.com/mtojek/integrations/blob/tips-for-devs/CONTRIBUTING.md#tips-for-building-integrations) and this pull request is aligned with them.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed this: should this be github.com/elastic/... instead of github.com/mtojek/.... Better yet, any way to make it a relative URL?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can live with a reference to master now. I don't know if it supports relative URL, will have to check it.


## Checklist

- [ ] I have reviewed [tips for building integrations](https://github.com/elastic/integrations/blob/tips-for-devs/CONTRIBUTING.md#tips-for-building-integrations) and this pull request is aligned with them.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, invalid branch. Fixed.

Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elasticmachine
Copy link
Copy Markdown

Package aws_bedrock - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=aws_bedrock

flexitrev added a commit that referenced this pull request Mar 28, 2025
* Add Cloudtrail Actor and Target

* Update toggle description

* Fix accountId typo

* Add versioning

* Fix ec2 events without complete response elements

* Improve error handling

* Improve error handling (add tag to the document on error)

* Use onBehalfOf in case of arn is not available in the user identity section

* Bump manifest version

<!-- Type of change
Please label this PR with one of the following labels, depending on the scope of your change:
- Bug
- Enhancement
- Breaking change
- Deprecation
-->

## Proposed commit message

<!-- Mandatory
Explain here the changes you made on the PR.

Please explain:

- WHAT: patterns used, algorithms implemented, design architecture, message processing, etc.
- WHY:  the rationale/motivation for the changes

This text will be pasted into the squash dialog when the change is committed and will be
a long term historical record of the change to help future contributors understand the
change, please help them by making it clear and comprehensive, they may be you.

If the commit title is adequate to describe both of these things, The text here may be omitted
or replaced with "See title". The title of the PR will be used as the commit message title when
the merge is made and the "See title" marker will be removed if present.

The text here and the PR title will be subject to the PR review process.
-->

## Checklist

- [ ] I have reviewed [tips for building integrations](https://github.com/elastic/integrations/blob/main/docs/tips_for_building_integrations.md) and this pull request is aligned with them.
- [ ] I have verified that all data streams collect metrics or logs.
- [ ] I have added an entry to my package's `changelog.yml` file.
- [ ] I have verified that Kibana version constraints are current according to [guidelines](https://github.com/elastic/elastic-package/blob/master/docs/howto/stack_version_support.md#when-to-update-the-condition).
- [ ] I have verified that any added dashboard complies with Kibana's [Dashboard good practices](https://docs.elastic.dev/ux-guidelines/data-viz/dashboard-good-practices)

## Author's Checklist

<!-- Recommended
Add a checklist of things that are required to be reviewed in order to have the PR approved
-->
- [ ]

## How to test this PR locally

<!-- Recommended
Explain here how this PR will be tested by the reviewer: commands, dependencies, steps, etc.
-->

## Related issues

<!-- Recommended
Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it.

- Closes #123
- Relates #123
- Requires #123
- Supersedes #123
-->
-

## Screenshots

<!-- Optional
Add here screenshots presenting:
- Kibana UI forms presenting configuration options exposed by the integration
- dashboards with collected metrics or logs
-->
andrewkroh added a commit to andrewkroh/integrations that referenced this pull request Aug 13, 2025
…tic#123)

Added configurable `oauth_endpoint_params` for greater flexibility.  An
example use case is to allow overriding the default grant_type to
support using providing a static refresh_token.

Introduce the ability to handle refresh token grant type in the OAuth2
flow for the o365 package.
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package otel_collector_internal_telemetry - 0.1.1 containing this change is available at https://epr.elastic.co/package/otel_collector_internal_telemetry/0.1.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants