Skip to content

[Windows] Fix mapping for field dns.answers#12226

Merged
jen-huang merged 0 commit intomainfrom
jh/windows-mapping-fix
Jan 6, 2025
Merged

[Windows] Fix mapping for field dns.answers#12226
jen-huang merged 0 commit intomainfrom
jh/windows-mapping-fix

Conversation

@jen-huang
Copy link
Copy Markdown
Contributor

Proposed commit message

This PR fixes the mapping for field dns.answers, changing it to group instead of object which aligns with other integrations that also use this ECS field.

v2.3.3 (prior version of this integration) continuously failed to install with mapping errors. I tested that this change fixes that.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@jen-huang jen-huang added Integration:windows Windows bugfix Pull request that fixes a bug issue labels Jan 3, 2025
@jen-huang jen-huang self-assigned this Jan 3, 2025
@jen-huang jen-huang requested review from a team as code owners January 3, 2025 23:25
@jen-huang jen-huang requested review from faec and khushijain21 January 3, 2025 23:25
@andrewkroh andrewkroh added the Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] label Jan 3, 2025
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @jen-huang

@elastic-sonarqube
Copy link
Copy Markdown

@jen-huang jen-huang merged commit 9c6fd11 into main Jan 6, 2025
@jen-huang jen-huang deleted the jh/windows-mapping-fix branch January 6, 2025 22:03
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package windows - 2.3.4 containing this change is available at https://epr.elastic.co/package/windows/2.3.4/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:windows Windows Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants