Skip to content

Fix handling of lists in 'Set ECS categorization fields' scripts#12161

Merged
marc-gr merged 0 commit intoelastic:mainfrom
joegallo:ecs-cat-fields-param-lists
Dec 27, 2024
Merged

Fix handling of lists in 'Set ECS categorization fields' scripts#12161
marc-gr merged 0 commit intoelastic:mainfrom
joegallo:ecs-cat-fields-param-lists

Conversation

@joegallo
Copy link
Copy Markdown
Contributor

Defensively copy list parameters in 'Set ECS categorization fields' scripts. See elastic/elasticsearch#91977.

@joegallo joegallo added the bugfix Pull request that fixes a bug issue label Dec 19, 2024
@joegallo
Copy link
Copy Markdown
Contributor Author

These def hm = new HashMap(...) bits are trying to work around the linked bug, but I think they're mistaken.

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 19, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@marc-gr marc-gr marked this pull request as ready for review December 19, 2024 07:48
@marc-gr marc-gr requested review from a team as code owners December 19, 2024 07:48
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #19687 succeeded b8937ce5c43457d2ae9a2909c30e25b568cd90d4

@elastic-sonarqube
Copy link
Copy Markdown

@andrewkroh andrewkroh added Integration:system System Integration:watchguard_firebox WatchGuard Firebox Integration:windows Windows Integration:zscaler_zia Zscaler Internet Access Integration:authentik authentik Integration:proofpoint_on_demand Proofpoint On Demand Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Dec 19, 2024
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joegallo Is there any means of performing an automated escape analysis on these scripts? I'd love to be able to put a static check into our package test tooling.

@joegallo
Copy link
Copy Markdown
Contributor Author

@joegallo Is there any means of performing an automated escape analysis on these scripts? I'd love to be able to put a static check into our package test tooling.

There's nothing built into Elasticsearch for that yet, but I'm going to think about it -- I realize that the current approach of 'just be careful/perfect all the time' is untenable.

@marc-gr marc-gr merged commit f8d008a into elastic:main Dec 27, 2024
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package authentik - 1.2.1 containing this change is available at https://epr.elastic.co/package/authentik/1.2.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package proofpoint_on_demand - 1.3.1 containing this change is available at https://epr.elastic.co/package/proofpoint_on_demand/1.3.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package system - 1.63.1 containing this change is available at https://epr.elastic.co/package/system/1.63.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package watchguard_firebox - 1.0.3 containing this change is available at https://epr.elastic.co/package/watchguard_firebox/1.0.3/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package windows - 2.3.3 containing this change is available at https://epr.elastic.co/package/windows/2.3.3/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package zscaler_zia - 3.6.1 containing this change is available at https://epr.elastic.co/package/zscaler_zia/3.6.1/

@joegallo joegallo deleted the ecs-cat-fields-param-lists branch December 31, 2024 17:37
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…stic#12161)

* There's no need to guard ctx with '?'

* Remove an unnecessary hashmap allocation

* Make these lambdas multiline

* Add missing semicolons

* Defensively copy list parameters

* Update versions

---------

Co-authored-by: Marc Guasch <marc.guasch@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…stic#12161)

* There's no need to guard ctx with '?'

* Remove an unnecessary hashmap allocation

* Make these lambdas multiline

* Add missing semicolons

* Defensively copy list parameters

* Update versions

---------

Co-authored-by: Marc Guasch <marc.guasch@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:authentik authentik Integration:proofpoint_on_demand Proofpoint On Demand Integration:system System Integration:watchguard_firebox WatchGuard Firebox Integration:windows Windows Integration:zscaler_zia Zscaler Internet Access Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants