Skip to content

okta: do not remove event.original in main ingest#12127

Merged
efd6 merged 0 commit intoelastic:mainfrom
efd6:12067-okta
Dec 17, 2024
Merged

okta: do not remove event.original in main ingest#12127
efd6 merged 0 commit intoelastic:mainfrom
efd6:12067-okta

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Dec 16, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 16, 2024
@efd6 efd6 self-assigned this Dec 16, 2024
@efd6 efd6 force-pushed the 12067-okta branch 2 times, most recently from 3ac0cfd to 006d383 Compare December 16, 2024 22:53
@efd6 efd6 mentioned this pull request Dec 16, 2024
Closed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 16, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Dec 16, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 16, 2024

💚 Build Succeeded

History

  • 💔 Build #19581 failed 3ac0cfd9de3ba28046d14218dddf30b87ff4f0ca

cc @efd6

@efd6 efd6 marked this pull request as ready for review December 16, 2024 23:17
@efd6 efd6 requested a review from a team as a code owner December 16, 2024 23:17
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 16, 2024

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

chrisberkhout
chrisberkhout approved these changes Dec 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if you provide an event with message and event.original, the event.original will be used and the message will be discarded.

Before this change it was the same, except the message field wouldn't be removed.

I the change is fine.

I wonder if we should be more consistent about using event.original as the source, and any other conventions necessary to make it easier to reprocess events.

@efd6
Copy link
Copy Markdown
Contributor Author

efd6 commented Dec 17, 2024

I wonder if we should be more consistent about using event.original as the source, and any other conventions necessary to make it easier to reprocess events.

I would like this. I think it's something that we should discuss for the integrations review document.

@efd6 efd6 merged commit d255da9 into elastic:main Dec 17, 2024
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 17, 2024

Package okta - 3.4.0 containing this change is available at https://epr.elastic.co/package/okta/3.4.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@efd6
okta: do not remove event.original in main ingest (elastic#12127)
206aee3
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@efd6
okta: do not remove event.original in main ingest (elastic#12127)
6f801d4
@efd6 efd6 deleted the 12067-okta branch February 5, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisberkhout chrisberkhout chrisberkhout approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @chrisberkhout