Skip to content

[digital_guardian] Correct time formats, data size parsing#12095

Merged
chrisberkhout merged 0 commit intoelastic:mainfrom
chrisberkhout:dg-arc-times-2
Dec 18, 2024
Merged

[digital_guardian] Correct time formats, data size parsing#12095
chrisberkhout merged 0 commit intoelastic:mainfrom
chrisberkhout:dg-arc-times-2

Conversation

@chrisberkhout
Copy link
Copy Markdown
Contributor

@chrisberkhout chrisberkhout commented Dec 13, 2024

Proposed commit message

[digital_guardian] Correct time formats, data size parsing

- Correct the `dg_time` format (may have AM/PM).
- Correct the `dg_processed_time` format (to `epoch_millis`).
- Process additional timestamp fields: `dg_local_timestamp`, `pi_fal`,
  `pi_fcl`, `pi_fml`.
- Add fallback/alternate formats for the string-valued time fields.
- For data size fields, add parsing logic.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chrisberkhout chrisberkhout added the bugfix Pull request that fixes a bug issue label Dec 13, 2024
@chrisberkhout chrisberkhout self-assigned this Dec 13, 2024
@chrisberkhout chrisberkhout added Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:digital_guardian Digital Guardian labels Dec 13, 2024
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 13, 2024

🚀 Benchmarks report

Package digital_guardian 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
arc 4926.11 2994.01 -1932.1 (-39.22%) 💔

To see the full report comment with /test benchmark fullreport

@chrisberkhout chrisberkhout changed the title [digital_guardian] Correct time format [digital_guardian] Correct time formats, data size parsing Dec 16, 2024
@chrisberkhout chrisberkhout marked this pull request as ready for review December 16, 2024 17:35
@chrisberkhout chrisberkhout requested a review from a team as a code owner December 16, 2024 17:35
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after conflicts resolved.

@chrisberkhout chrisberkhout enabled auto-merge (squash) December 18, 2024 11:07
@chrisberkhout chrisberkhout merged commit a84a59d into elastic:main Dec 18, 2024
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #19573 succeeded 21e7d7fb91f0df78f63da3aee5b5ca5f4cae7c4f
  • 💔 Build #19572 failed 8ec602d1f5af325913244303e3a550c3ff7ed830
  • 💚 Build #19462 succeeded bfd5f78e8867b265a3272df7b2d8c8352c57da5f

cc @chrisberkhout

@elastic-sonarqube
Copy link
Copy Markdown

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package digital_guardian - 1.3.1 containing this change is available at https://epr.elastic.co/package/digital_guardian/1.3.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…2095)

- Correct the `dg_time` format (may have AM/PM).
- Correct the `dg_processed_time` format (to `epoch_millis`).
- Process additional timestamp fields: `dg_local_timestamp`, `pi_fal`,
  `pi_fcl`, `pi_fml`.
- Add fallback/alternate formats for the string-valued time fields.
- For data size fields, add parsing logic.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…2095)

- Correct the `dg_time` format (may have AM/PM).
- Correct the `dg_processed_time` format (to `epoch_millis`).
- Process additional timestamp fields: `dg_local_timestamp`, `pi_fal`,
  `pi_fcl`, `pi_fml`.
- Add fallback/alternate formats for the string-valued time fields.
- For data size fields, add parsing logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:digital_guardian Digital Guardian Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants