Skip to content

[windows] Fix powerhsell context info value split#11938

Merged
marc-gr merged 0 commit intoelastic:mainfrom
marc-gr:fix/windows-context-info
Dec 2, 2024
Merged

[windows] Fix powerhsell context info value split#11938
marc-gr merged 0 commit intoelastic:mainfrom
marc-gr:fix/windows-context-info

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Dec 2, 2024

Proposed commit message

In some systems context info seems to have Key value separators mixed with = and :. This fixes the pipeline to account for this case.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@marc-gr marc-gr added Integration:windows Windows bugfix Pull request that fixes a bug issue Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] labels Dec 2, 2024
@marc-gr marc-gr force-pushed the fix/windows-context-info branch from f0164fc to 15a04cb Compare December 2, 2024 07:30
@marc-gr marc-gr marked this pull request as ready for review December 2, 2024 07:30
@marc-gr marc-gr requested review from a team as code owners December 2, 2024 07:30
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Dec 2, 2024
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

Package windows 👍(4) 💚(2) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
powershell_operational 4807.69 3787.88 -1019.81 (-21.21%) 💔
sysmon_operational 3134.8 2590.67 -544.13 (-17.36%) 💔
windows_defender 14925.37 10101.01 -4824.36 (-32.32%) 💔

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link
Copy Markdown

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@marc-gr marc-gr merged commit 3b41c93 into elastic:main Dec 2, 2024
@marc-gr marc-gr deleted the fix/windows-context-info branch December 2, 2024 10:38
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package windows - 2.3.2 containing this change is available at https://epr.elastic.co/package/windows/2.3.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:windows Windows Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants