Skip to content

[Custom AWS logs] Remove ingest pipeline option#11681

Merged
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:remove_ingest_pipeline
Nov 12, 2024
Merged

[Custom AWS logs] Remove ingest pipeline option#11681
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:remove_ingest_pipeline

Conversation

@kaiyan-sheng
Copy link
Copy Markdown

@kaiyan-sheng kaiyan-sheng commented Nov 8, 2024

Proposed commit message

Remove ingest pipeline option in config for custom aws logs integration. This option does not work, whatever is put in as the value for this config parameter, was being ignored. The way to change ingest pipeline is to choose Add custom pipeline:

Screenshot 2024-11-08 at 2 33 53 PM

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:aws_logs Custom AWS Logs labels Nov 8, 2024
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@elastic-sonarqube
Copy link
Copy Markdown

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review November 8, 2024 22:31
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner November 8, 2024 22:31
@kaiyan-sheng kaiyan-sheng self-assigned this Nov 8, 2024
@andrewkroh andrewkroh added the Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] label Nov 8, 2024
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 822ae46 into elastic:main Nov 12, 2024
@kaiyan-sheng kaiyan-sheng deleted the remove_ingest_pipeline branch November 12, 2024 14:56
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package aws_logs - 1.4.1 containing this change is available at https://epr.elastic.co/package/aws_logs/1.4.1/

kaiyan-sheng pushed a commit that referenced this pull request Nov 22, 2024
* Revert "[Custom AWS logs] Remove ingest pipeline option (#11681)"

This reverts commit 822ae46.
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
* Revert "[Custom AWS logs] Remove ingest pipeline option (#11681)"

This reverts commit 19d5d59.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* Remove ingest pipeline option from custom aws logs

* add changelog
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* Revert "[Custom AWS logs] Remove ingest pipeline option (elastic#11681)"

This reverts commit 19d5d59.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
* Revert "[Custom AWS logs] Remove ingest pipeline option (#11681)"

This reverts commit 6ed161c.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* Remove ingest pipeline option from custom aws logs

* add changelog
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* Revert "[Custom AWS logs] Remove ingest pipeline option (elastic#11681)"

This reverts commit 6ed161c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:aws_logs Custom AWS Logs Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Custom AWS Logs]: Ingest pipeline field does not get applied

4 participants