Skip to content

[vSphere] Add and update Dashboards#11637

Merged
kush-elastic merged 0 commit intoelastic:mainfrom
kush-elastic:vSphere-dashboards
Dec 19, 2024
Merged

[vSphere] Add and update Dashboards#11637
kush-elastic merged 0 commit intoelastic:mainfrom
kush-elastic:vSphere-dashboards

Conversation

@kush-elastic
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic commented Nov 5, 2024 •
edited
Loading

  • Enhancement

Description

Add New dashboards
Update existing dashboards

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Screen Shots

Screen shots has been added to integration, please review from integration files.

Related issues

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Nov 5, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:vsphere VMware vSphere labels Nov 5, 2024
@kush-elastic kush-elastic self-assigned this Nov 6, 2024
@kush-elastic kush-elastic marked this pull request as ready for review November 14, 2024 07:15
@kush-elastic kush-elastic requested a review from a team as a code owner November 14, 2024 07:15
@kush-elastic kush-elastic added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Nov 14, 2024
harnish-crest-data
harnish-crest-data reviewed Nov 20, 2024
View reviewed changes
harnish-crest-data
harnish-crest-data reviewed Nov 20, 2024
View reviewed changes
harnish-crest-data
harnish-crest-data approved these changes Nov 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@harnish-crest-data harnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. Otherwise LGTM!

harnish-crest-data
harnish-crest-data reviewed Nov 21, 2024
View reviewed changes
@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented Nov 26, 2024 •
edited
Loading

Review for Host Dashboard:

  • This looks to be an overview dashboard as we have host, datatstore, network related visualzations.
  • There are visualizations that use the word "stacked" in the title. We don't need to use the word while using stacked visualization
  • Host activity over time: What activity are we showing here ? Whats the count in this chart ? Here I don't think we need to show the no of documents in the chart. Also, host should be represented by just ip. Showing id in the panel can confuse the user
  • In datastore types, I don't see the types listed on the right side of the chart ?
  • We should not have [metrics vsphere] in title of every panel. Any reason why it us there ?
  • Free/Free CPU should not have mention of cluster
  • Y axis change on the memory/CPU/datastore panels
  • Bucket script removal in the panels
  • Top datastore panel to be moved to datastore dashboard

Will be reviewing others as well in next comments. Please note, I am taking a look at screenshots directly for review as thats the best way to review dashboard changes.

@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented Nov 27, 2024 •
edited
Loading

Datastore dashboard review:

  • Y axis for many panels is missing.
  • 2 panels have same title. Pls change that
  • Datastore activity over time. (Lets make it similar to what we decided for Host)

@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented Nov 28, 2024

Resourcepool dashboard review:

  1. Private vs shared memory usage will show for all the resourcepools ? Won't the graph get chaotic ?

Virtualmachine dashboard review:

  1. VM's placement on ESXI hosts: Too many VM's get listed. We can list the top 10, IMO.
  2. VM's per ESXI host: Does that tell about the number of VM's per EXI host? The screenshot doesn't give clarity
  3. Networks from virtualmachine should be renamed as Networks associated with Virtualmachine

@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented Nov 28, 2024

The cluster and network are in the same dashboard. Let's give a horizontal divisioning rather than vertical divisioning between cluster and network.

ishleenk17
ishleenk17 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good now.
Let's get the CI passing and we are good to merge then

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 10, 2024

💚 Build Succeeded

History

  • 💔 Build #18952 failed 8913fbe51915043df8a49017407f7bbbf10b94f4
  • 💔 Build #18863 failed 75097d47a0f4dfd356c43284df9f8a9ffdd94c28
  • 💔 Build #18537 failed 1ac8c7811c4db4f7e498df0c29eb0b98deb6c6ac
  • 💚 Build #18489 succeeded 073f3d039c57ad9e6439242c4dcb361d5c5e0599
  • 💚 Build #18438 succeeded cb46a8b87bc5506f6883a5a38501ae4fe339dfe0

cc @kush-elastic

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Dec 10, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@kush-elastic kush-elastic merged commit 14df431 into elastic:main Dec 19, 2024
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 19, 2024

Package vsphere - 1.16.3 containing this change is available at https://epr.elastic.co/package/vsphere/1.16.3/

harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@kush-elastic @harnish-crest-data
[vSphere] Add and update Dashboards (elastic#11637)
50b3666 
* add and update dashboards

* update changelog entry

* update dashboards

* update kibana version

* update changelog entry

* add dashboards screen shots

* fix changelog

* Update packages/vsphere/changelog.yml

Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>

* update remaining dashboards with id changes

* update kibana version to 8.16.2

* Hosts Overview

* Cluster and Network Status Insights

* Comprehensive Storage Overview

* Resource Pools Overview

* VMs overview

* update dashboards and its screen shots

---------

Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>
harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@kush-elastic @harnish-crest-data
[vSphere] Add and update Dashboards (elastic#11637)
17a763b 
* add and update dashboards

* update changelog entry

* update dashboards

* update kibana version

* update changelog entry

* add dashboards screen shots

* fix changelog

* Update packages/vsphere/changelog.yml

Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>

* update remaining dashboards with id changes

* update kibana version to 8.16.2

* Hosts Overview

* Cluster and Network Status Insights

* Comprehensive Storage Overview

* Resource Pools Overview

* VMs overview

* update dashboards and its screen shots

---------

Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>
@kush-elastic kush-elastic deleted the vSphere-dashboards branch February 11, 2025 05:00
@andrewkroh andrewkroh removed the Integration:vsphere VMware vSphere label Mar 13, 2025
@andrewkroh andrewkroh removed the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

@lucian-ioan lucian-ioan Awaiting requested review from lucian-ioan

+1 more reviewer

@harnish-crest-data harnish-crest-data harnish-crest-data approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kush-elastic kush-elastic

Labels

enhancement New feature or request Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kush-elastic @ishleenk17 @elasticmachine @harnish-crest-data @andrewkroh