Docker: bump package-spec version to 3.2.2#11196
Merged
zmoog merged 7 commits intoelastic:mainfrom Sep 24, 2024
Merged
Conversation
Contributor
Author
|
I'm not 100% sure about |
| fields: | ||
| - name: stats.* | ||
| type: object | ||
| object_type: float |
Contributor
There was a problem hiding this comment.
I think the correct would be long or double. But looking at the stats, I would pick long
The package-spec >= 3.2 does not work on 9.0 and Serverless
MichaelKatsoulis
approved these changes
Sep 20, 2024
We picked package-spec 3.0.4 instead of 3.2.2. As of today, kibana requires spec 3.0.x to run on Serverless.
Contributor
|
LGTM, package build is successful without any errors |
gizas
approved these changes
Sep 23, 2024
Contributor
Author
|
@gizas @MichaelKatsoulis I'm testing this one more time with package-spec 3.2.2; maybe I did something wrong last time. Stay tuned! |
Contributor
Author
|
Tested on stack version 9.0.0-SNAPSHOT and package-spec 3.2.2: And I can successfully see and install the Docker integration: CleanShot.2024-09-23.at.17.24.11.mp4 |
The latest test run shows it works on 3.2.2 too, I probably made some mistakes when I tested it before.
Contributor
Author
|
@gizas @MichaelKatsoulis, could you take a final look when you have time? |
💚 Build Succeeded
History
cc @zmoog |
|
Contributor
LGTM! |
Contributor
|
all good @zmoog from my side! |
|
Package docker - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=docker |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
Bump package-spec version to 3.2.2. Reasons: - Align with best practices and requirements in package-spec v3. - Serverless requires a package-spec version of 3.0.x. Notes: - As of today, to test the Docker integration on non-serverless stack version 9.0, you must build the package with a `conditions.kibana.version: >= 8.8.0`. - Future elastic-package version elastic/elastic-package#2116 will allow test the integration on stack version `9.0.0-SNAPSHOT` without changing `conditions.kibana.version`.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
Bump package-spec version to 3.2.2. Reasons: - Align with best practices and requirements in package-spec v3. - Serverless requires a package-spec version of 3.0.x. Notes: - As of today, to test the Docker integration on non-serverless stack version 9.0, you must build the package with a `conditions.kibana.version: >= 8.8.0`. - Future elastic-package version elastic/elastic-package#2116 will allow test the integration on stack version `9.0.0-SNAPSHOT` without changing `conditions.kibana.version`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Bump package-spec version to 3.2.2.
Reasons:
Notes:
conditions.kibana.version: >= 8.8.0.9.0.0-SNAPSHOTwithout changingconditions.kibana.version.Checklist
changelog.ymlfile.Related issues