Skip to content

Update packages to use Elastic Agent images based on Ubuntu#11007

Merged
mrodm merged 8 commits intoelastic:mainfrom
mrodm:update-packages-wolfi-compatible-tests
Sep 5, 2024
Merged

Update packages to use Elastic Agent images based on Ubuntu#11007
mrodm merged 8 commits intoelastic:mainfrom
mrodm:update-packages-wolfi-compatible-tests

Conversation

@mrodm
Copy link
Copy Markdown
Collaborator

@mrodm mrodm commented Sep 4, 2024 •
edited
Loading

Proposed commit message

Once Elastic Agent images based on Wolfi are enabled for testing in 8.16.0-SNAPSHOT (tested here https://github.com/elastic/integrations/pull/10933/files) , there are some packages that their system tests fail for different reasons: permission logs, missing journalctl or not supported package manager.

This PR updates their configuration files to allow use the Elastic Agent images
based on Ubuntu or use user root for tests once it is set to run system tests with Wolfi images by default in #10969.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • [ ] I have verified that all data streams collect metrics or logs.
  • [ ] I have added an entry to my package's changelog.yml file.
  • [ ] I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

Related issues

Screenshots

@mrodm mrodm self-assigned this Sep 4, 2024
@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Sep 4, 2024

I guess that the config below stands for ubuntu images right?

agent:
  base_image: systemd

@mrodm
Copy link
Copy Markdown
Collaborator Author

mrodm commented Sep 4, 2024

I guess that the config below stands for ubuntu images right?

agent:
  base_image: systemd

When that setting is systemd , elastic-package will use the non-complete images, so it would be:
docker.elastic.co/elastic-agent/elastic-agent

If that setting is complete, elastic-package will use the complete image: docker.elastic.co/elastic-agent/elastic-agent-complete

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 4, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@mrodm mrodm marked this pull request as ready for review September 4, 2024 16:03
@mrodm mrodm requested review from a team as code owners September 4, 2024 16:03
@mrodm mrodm requested review from VihasMakwana and faec September 4, 2024 16:03
mrodm
mrodm commented Sep 4, 2024
View reviewed changes
packages/apache_tomcat/_dev/deploy/variants.yml
Copy link
Copy Markdown
Collaborator Author

@mrodm mrodm Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved variants file in order to be considered by elastic-package.
It is expected to be in _dev/deploy folder: https://github.com/elastic/package-spec/blob/aacaf7b19f51d54b394a7640e6898b8398d88cc8/spec/integration/_dev/deploy/spec.yml#L22

@andrewkroh andrewkroh added Integration:apache_tomcat Apache Tomcat Integration:iptables Iptables Integration:journald Custom Journald logs Integration:microsoft_sqlserver Microsoft SQL Server Integration:stan STAN Integration:system_audit System Audit Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] labels Sep 5, 2024
@andrewkroh andrewkroh added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] labels Sep 5, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 5, 2024

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 5, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 5, 2024

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Sep 5, 2024

I think according to @cmacknz's comment this should rather close all the issues mentioned in the description and not only relate to them.

@mrodm mrodm mentioned this pull request Sep 5, 2024
Closed
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Sep 5, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 5, 2024

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm requested a review from shmsr September 5, 2024 09:55
@mrodm
Copy link
Copy Markdown
Collaborator Author

mrodm commented Sep 5, 2024

I think according to @cmacknz's comment this should rather close all the issues mentioned in the description and not only relate to them.

Ok, I'll update the description, so those issues are closed.

Related to the permissions issue found here, there are already two issues in elastic-package that could be interesting:

@mrodm mrodm merged commit e882d65 into elastic:main Sep 5, 2024
@mrodm mrodm deleted the update-packages-wolfi-compatible-tests branch September 5, 2024 11:18
@mrodm mrodm mentioned this pull request Sep 5, 2024
Closed
4 tasks
@mrodm mrodm mentioned this pull request Sep 20, 2024
Merged
2 tasks
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@mrodm
Update packages to use Elastic Agent images based on Ubuntu (elastic#…
5a931ba 
…11007)

Updated configuration files of the system tests of the packages
failing when Elastic Agent images based on Wolfi are used in tests.
This PR updates these configuration files to allow using the Elastic
Agent images based on Ubuntu or setting the user root for tests to
avoid failures when testing those packages.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@mrodm
Update packages to use Elastic Agent images based on Ubuntu (elastic#…
a2985a5 
…11007)

Updated configuration files of the system tests of the packages
failing when Elastic Agent images based on Wolfi are used in tests.
This PR updates these configuration files to allow using the Elastic
Agent images based on Ubuntu or setting the user root for tests to
avoid failures when testing those packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@jlind23 jlind23 jlind23 approved these changes

@shmsr shmsr shmsr approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@mrodm mrodm

Labels

Integration:apache_tomcat Apache Tomcat Integration:iptables Iptables Integration:journald Custom Journald logs Integration:microsoft_sqlserver Microsoft SQL Server Integration:stan STAN Integration:system_audit System Audit Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform]

Projects

None yet

Milestone

No milestone

6 participants

@mrodm @jlind23 @elasticmachine @jsoriano @andrewkroh @shmsr