Skip to content

System Integration: Rename Desconnections to Disconnections#10934

Merged
marc-gr merged 4 commits intomainfrom
windows/fix-typo-in-visual-title
Nov 5, 2024
Merged

System Integration: Rename Desconnections to Disconnections#10934
marc-gr merged 4 commits intomainfrom
windows/fix-typo-in-visual-title

Conversation

@cp-elastic
Copy link
Copy Markdown
Contributor

@cp-elastic cp-elastic commented Aug 29, 2024 •
edited
Loading

Proposed commit message

Fix typo in RDP Connections and Desconnections to RDP Connections and Disconnections

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

I'm not sure this warrants a changelog entry, nothing has functionally changed.

@cp-elastic cp-elastic requested a review from a team as a code owner August 29, 2024 13:19
@andrewkroh andrewkroh added Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Aug 29, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 29, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Aug 30, 2024
@anil-elastic
Copy link
Copy Markdown
Contributor

anil-elastic commented Sep 4, 2024

@cp-elastic you also need to update changelog.yml and manifest.yml also.

@cp-elastic cp-elastic requested review from a team as code owners September 4, 2024 12:08
@andrewkroh andrewkroh added the enhancement New feature or request label Sep 4, 2024
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Sep 4, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@botelastic
Copy link
Copy Markdown

botelastic bot commented Oct 4, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 4, 2024
@botelastic
Copy link
Copy Markdown

botelastic bot commented Nov 3, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Nov 3, 2024
@marc-gr marc-gr reopened this Nov 5, 2024
@botelastic botelastic bot removed the Stalled label Nov 5, 2024
muthu-mps
muthu-mps reviewed Nov 5, 2024
View reviewed changes
marc-gr
marc-gr reviewed Nov 5, 2024
View reviewed changes
@marc-gr @muthu-mps
Apply suggestions from code review
6005b53 
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
@muthu-mps muthu-mps changed the title Enhancement: Rename Desconnections to Disconnections System Integration: Rename Desconnections to Disconnections Nov 5, 2024
@marc-gr marc-gr enabled auto-merge (squash) November 5, 2024 11:09
@marc-gr marc-gr merged commit 89457ed into main Nov 5, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 5, 2024

💚 Build Succeeded

History

@marc-gr marc-gr deleted the windows/fix-typo-in-visual-title branch November 5, 2024 11:10
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Nov 5, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Nov 5, 2024

Package system - 1.62.1 containing this change is available at https://epr.elastic.co/search?package=system

@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue and removed enhancement New feature or request labels Nov 5, 2024
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@cp-elastic @marc-gr @muthu-mps
System Integration: Rename Desconnections to Disconnections (elastic#…
6556045 
…10934)

* Rename Desconnections to Disconnections

* Increment version, add changelog entry

* Apply suggestions from code review

Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

---------

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@cp-elastic @marc-gr @muthu-mps
System Integration: Rename Desconnections to Disconnections (elastic#…
f285e38 
…10934)

* Rename Desconnections to Disconnections

* Increment version, add changelog entry

* Apply suggestions from code review

Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

---------

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-gr marc-gr marc-gr approved these changes

@nfritts nfritts nfritts approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

No one assigned

Labels

bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cp-elastic @elasticmachine @anil-elastic @marc-gr @nfritts @muthu-mps @andrewkroh