Skip to content

[system] Fix broken visualization for User Renamed Metric in User Management Events Dashboard#10698

Merged
ishleenk17 merged 2 commits intoelastic:mainfrom
nicpenning:main
Aug 23, 2024
Merged

[system] Fix broken visualization for User Renamed Metric in User Management Events Dashboard#10698
ishleenk17 merged 2 commits intoelastic:mainfrom
nicpenning:main

Conversation

@nicpenning
Copy link
Copy Markdown
Contributor

@nicpenning nicpenning commented Aug 5, 2024

Please label this PR with one of the following labels, depending on the scope of your change:

  • Bug

Proposed commit message

See title

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related: #10431 -> All visualizations implemented here work, except this one. A missed ")" is causing this to break.

Screenshots

image

@nicpenning nicpenning requested review from a team as code owners August 5, 2024 15:41
@nicpenning
Copy link
Copy Markdown
Contributor Author

Ready for tests. Missed a closing parenthesis.

@andrewkroh andrewkroh added Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Aug 5, 2024
@marc-gr
Copy link
Copy Markdown
Contributor

marc-gr commented Aug 7, 2024

/test

@elasticmachine
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@elastic-sonarqube
Copy link
Copy Markdown

@nicpenning
Copy link
Copy Markdown
Contributor Author

@nfritts @muthu-mps, please review?

@nicpenning
Copy link
Copy Markdown
Contributor Author

Pinging here again.

@andrewkroh andrewkroh added the bugfix Pull request that fixes a bug issue label Aug 19, 2024
@nicpenning
Copy link
Copy Markdown
Contributor Author

So close, just need another review here.

Copy link
Copy Markdown
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ishleenk17 ishleenk17 merged commit 6b8379d into elastic:main Aug 23, 2024
@elasticmachine
Copy link
Copy Markdown

Package system - 1.60.3 containing this change is available at https://epr.elastic.co/search?package=system

@nicpenning
Copy link
Copy Markdown
Contributor Author

Thank you very much!

@andrewkroh andrewkroh added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Aug 30, 2024
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…agement Events Dashboard (elastic#10698)

* Fix broken visualization

* Update changelog
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…agement Events Dashboard (elastic#10698)

* Fix broken visualization

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants