Skip to content

[system] Windows Security dashboard fix (adds windows.forwarded)#10439

Merged
marc-gr merged 8 commits intoelastic:mainfrom
nicpenning:system_windows_dashboard_fix
Aug 2, 2024
Merged

[system] Windows Security dashboard fix (adds windows.forwarded)#10439
marc-gr merged 8 commits intoelastic:mainfrom
nicpenning:system_windows_dashboard_fix

Conversation

@nicpenning
Copy link
Copy Markdown
Contributor

@nicpenning nicpenning commented Jul 9, 2024

  • Bug

Proposed commit message

See title and Issue -> This fixes some discrepancies with some searches and visuals that did not include windows.forward. This adds that as an OR to make sure those events are included in all of the Windws Security dashboards.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@nicpenning nicpenning requested review from a team as code owners July 9, 2024 18:13
@nicpenning
Copy link
Copy Markdown
Contributor Author

nicpenning commented Jul 9, 2024

Ready to test.

@marc-gr
Copy link
Copy Markdown
Contributor

marc-gr commented Jul 10, 2024

/test

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 10, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@nicpenning
Copy link
Copy Markdown
Contributor Author

nicpenning commented Jul 13, 2024

Not sure what to do with this 75% code coverage. Is this stalled on my behalf? Please let me know how to proceed on this 😀 itching for these fixes.

@nicpenning
Copy link
Copy Markdown
Contributor Author

nicpenning commented Jul 19, 2024

Looks like conflicts are starting to set in could someone please review soon?

@nicpenning
Copy link
Copy Markdown
Contributor Author

nicpenning commented Jul 19, 2024

Resolved conflicts.

@andrewkroh andrewkroh added Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 19, 2024
@nicpenning
Copy link
Copy Markdown
Contributor Author

nicpenning commented Jul 23, 2024

👋 just checking in. Please let me know how to proceed.

@andrewkroh
Copy link
Copy Markdown
Member

andrewkroh commented Jul 23, 2024

I believe this requires the review of @elastic/obs-infraobs-integrations because of how CODEOWNERS is configured relating to the dashboards directory.

@nicpenning
Copy link
Copy Markdown
Contributor Author

nicpenning commented Jul 26, 2024

Yet another PR approved and now I have more conflicts to resolve. Am I missing something here?

@nicpenning
Copy link
Copy Markdown
Contributor Author

nicpenning commented Jul 26, 2024

Conflict resolved. I know that it is assigned to elastic/obs-infraobs-integrations and elastic/sec-linux-platform but it has little to do with either of those teams, especially Linux since this is a Windows Security dashboard. Please advise!

@nicpenning
Copy link
Copy Markdown
Contributor Author

nicpenning commented Aug 2, 2024

Resolved conflicts, again.

muthu-mps
muthu-mps approved these changes Aug 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner approval.

@marc-gr marc-gr enabled auto-merge (squash) August 2, 2024 12:18
@marc-gr
Copy link
Copy Markdown
Contributor

marc-gr commented Aug 2, 2024

/test

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 2, 2024

💚 Build Succeeded

History

@marc-gr marc-gr merged commit e56a40c into elastic:main Aug 2, 2024
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Aug 2, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 2, 2024

Package system - 1.60.2 containing this change is available at https://epr.elastic.co/search?package=system

@nicpenning nicpenning deleted the system_windows_dashboard_fix branch August 2, 2024 15:07
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@nicpenning
[system] Windows Security dashboard fix (adds windows.forwarded) (ela…
80454b0 
…stic#10439)

* Update visuals and searches with windows.forwarded

* build, test and update changelog

* update changelog PR

* Update manifest.yml
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@nicpenning
[system] Windows Security dashboard fix (adds windows.forwarded) (ela…
e485b8c 
…stic#10439)

* Update visuals and searches with windows.forwarded

* build, test and update changelog

* update changelog PR

* Update manifest.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-gr marc-gr marc-gr approved these changes

@nfritts nfritts nfritts approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

No one assigned

Labels

Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[system] Windows Security - Use Managment Events dashboard missing forwarded events

6 participants

@nicpenning @marc-gr @elasticmachine @andrewkroh @nfritts @muthu-mps