Skip to content

[Linux] Add processors capability to Linux Metrics#10314

Merged
rdner merged 5 commits intoelastic:mainfrom
steffenstruebe:master
Aug 1, 2024
Merged

[Linux] Add processors capability to Linux Metrics#10314
rdner merged 5 commits intoelastic:mainfrom
steffenstruebe:master

Conversation

@steffenstruebe
Copy link
Copy Markdown
Contributor

@steffenstruebe steffenstruebe commented Jul 1, 2024 •
edited by rdner
Loading

Proposed commit message

Add processors capability to Linux Metrics

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

On each our elastic-agents wie configured some variables to identify our systems in the local elastic-agent.yml:

providers:
  local:
    vars:
      acme_serverid: '12345678-abcd-1234-5678-abcdefgh1234'
      acme_systemid: '87654321-b769-04d5-c851-e8bb5044fb4e'

In the integration settings we consume these variables by following processors:
image

And we can now see our custom ids in the stream to be able to use these for mappings to the rest of our managment tools.
image

Related issues

Screenshots

@steffenstruebe steffenstruebe requested a review from a team as a code owner July 1, 2024 15:19
@steffenstruebe steffenstruebe requested review from belimawr and rdner July 1, 2024 15:19
@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Jul 1, 2024 •
edited
Loading

💚 CLA has been signed

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Jul 1, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 1, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert
Copy link
Copy Markdown
Contributor

pierrehilbert commented Jul 1, 2024

Hey @steffenstruebe
Thanks for your contribution.
Could you please sign our CLA? We will have someone from our team to review your work after that.

belimawr
belimawr requested changes Jul 1, 2024
View reviewed changes
@steffenstruebe steffenstruebe requested a review from belimawr July 1, 2024 16:04
belimawr
belimawr requested changes Jul 2, 2024
View reviewed changes
@steffenstruebe steffenstruebe requested a review from belimawr July 2, 2024 16:41
@pierrehilbert
Copy link
Copy Markdown
Contributor

pierrehilbert commented Jul 4, 2024

/test

belimawr
belimawr approved these changes Jul 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @rdner I'll be on PTO soon, can you keep an eye on this PR and make sure it gets merged?

@belimawr
Copy link
Copy Markdown
Contributor

belimawr commented Jul 10, 2024

buildkite test this

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 10, 2024

💚 Build Succeeded

History

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Jul 10, 2024

Quality Gate failed Quality Gate failed

Failed conditions
51.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

rdner
rdner requested changes Jul 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR requires tests, I doubt that in the current form it actually works correctly because of the YAML indentation.

@andrewkroh andrewkroh added the Integration:linux Linux Metrics label Jul 19, 2024
@steffenstruebe steffenstruebe requested a review from rdner July 29, 2024 13:41
@rdner rdner merged commit 1284b90 into elastic:main Aug 1, 2024
@steffenstruebe steffenstruebe deleted the master branch August 1, 2024 12:42
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 1, 2024

Package linux - 0.6.10 containing this change is available at https://epr.elastic.co/search?package=linux

@LaZyDK LaZyDK mentioned this pull request Aug 8, 2024
Merged
4 tasks
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@steffenstruebe
[Linux] Add processors capability to Linux Metrics (elastic#10314)
ba8a406 
Add processors capability to Linux Metrics
Fix predefined processors.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@steffenstruebe
[Linux] Add processors capability to Linux Metrics (elastic#10314)
41e15f2 
Add processors capability to Linux Metrics
Fix predefined processors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert left review comments

@belimawr belimawr belimawr approved these changes

@rdner rdner rdner approved these changes

+1 more reviewer

@joergdeutschmann joergdeutschmann joergdeutschmann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Integration:linux Linux Metrics Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@steffenstruebe @elasticmachine @pierrehilbert @belimawr @rdner @joergdeutschmann @andrewkroh