Skip to content

AWS: TargetResponseTime metrics added to Application elb#10181

Merged
anil-elastic merged 4 commits intoelastic:mainfrom
anil-elastic:integrations-9201
Jul 2, 2024
Merged

AWS: TargetResponseTime metrics added to Application elb#10181
anil-elastic merged 4 commits intoelastic:mainfrom
anil-elastic:integrations-9201

Conversation

@anil-elastic
Copy link
Copy Markdown
Contributor

@anil-elastic anil-elastic commented Jun 18, 2024 •
edited
Loading

Proposed commit message

Added TargetResponseTime metrics in AWS Application ELB.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

I've tested with elastic-package, and run the tests and TargetResponseTime comes into elb metrics.

"aws": {
      "applicationelb": {
        "metrics": {
          "HealthyHostCount": {
            "max": 1
          },
          "RequestCount": {
            "sum": 4
          },
          "TargetResponseTime": {
            "avg": 0.0014383333333333333
          },
          "UnHealthyHostCount": {
            "max": 0
          }
        }
      },

Screenshots

@anil-elastic anil-elastic requested review from a team as code owners June 18, 2024 17:07
@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Jun 18, 2024 •
edited
Loading

💚 CLA has been signed

@anil-elastic
Copy link
Copy Markdown
Contributor Author

anil-elastic commented Jun 18, 2024

/test

1 similar comment
@gpop63
Copy link
Copy Markdown
Contributor

gpop63 commented Jun 18, 2024

/test

@gpop63 gpop63 requested review from gpop63 and lucian-ioan June 18, 2024 17:59
@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Jun 19, 2024

I understand this is a simple enhancement.

Is there a plan to display the newly added field under the existing dashboard?

This change must be considered alongside other issues mentioned here, especially the challenges of dashboarding for ELB metrics and logs.

agithomas
agithomas reviewed Jun 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviews shared.

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Jun 19, 2024

Please regenerate the README, checkin the README changes to avoid buildkite failure.

agithomas
agithomas reviewed Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments added

@anil-elastic
Copy link
Copy Markdown
Contributor Author

anil-elastic commented Jun 21, 2024

/test

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

gpop63
gpop63 reviewed Jun 21, 2024
View reviewed changes
@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented Jun 21, 2024

@lucabelluccini : I think this was the customer enhancement request you were discussing with me.
The PR is already in works for adding the TargetResponseTime metric.

@anil-elastic @gpop63
Update packages/aws/changelog.yml with correct PR Id
a956561 
Co-authored-by: Gabriel Pop <94497545+gpop63@users.noreply.github.com>
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 21, 2024

💚 Build Succeeded

History

cc @anil-elastic

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Jun 21, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@anil-elastic anil-elastic requested a review from agithomas July 2, 2024 08:34
@anil-elastic
Copy link
Copy Markdown
Contributor Author

anil-elastic commented Jul 2, 2024

Reply to @agi comment: #10181 (comment)

I had discussion with @agi and according to @agithomas Customers are often getting confused with empty fields in their dashboard.There is ongoing issue to split elb data stream into 3 different data streams: application_elb, network_elb, and classic_elb as mentioned in this ticket #4800.

I have also created backlog ticket for create a dashboard panel for ALB.
#10326

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Jul 2, 2024

I understand this is a simple enhancement.

Is there a plan to display the newly added field under the existing dashboard?

This change must be considered alongside other issues mentioned here, especially the challenges of dashboarding for ELB metrics and logs.

Based on my discussion with @anil-elastic , i understand the field is relevant when an ALB is configured.

Adding a dashboard panel at this stage will add more problems to the customers as mentioned here.

Hence the #10326 is created as a backlog issue, which can be taken up along with the enhancement request of separate OOTB dashboards for various LBs

agithomas
agithomas approved these changes Jul 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anil-elastic anil-elastic merged commit 0eb2de5 into elastic:main Jul 2, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 2, 2024

Package aws - 2.16.0 containing this change is available at https://epr.elastic.co/search?package=aws

@agithomas agithomas mentioned this pull request Jul 12, 2024
Closed
@anil-elastic anil-elastic deleted the integrations-9201 branch August 16, 2024 07:56
@jkomara jkomara mentioned this pull request Jul 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpop63 gpop63 gpop63 approved these changes

@agithomas agithomas agithomas approved these changes

@lucian-ioan lucian-ioan Awaiting requested review from lucian-ioan

Assignees

@anil-elastic anil-elastic

Labels

Integration:aws AWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TargetResponseTime metric in ELB agent configuration,

5 participants

@anil-elastic @gpop63 @agithomas @elasticmachine @ishleenk17