Conversation
f9b751a to
eed504f
Compare
0cef359 to
389f2ae
Compare
Author
|
My upstream PR was merged more quickly than I had thought, so I'll close this PR in favour of merging with upstream (#7) and adding a 2nd PR with just the changes for Hapi 18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently CI fails on
master. This PR is an attempt to clean up CI so it's all green.It coveres two things:
@hapi/good(Create ci-plugin.yml hapijs/good#639). However, that PR hasn't yet been merged because their CI is also flaky just as ours is.I'm planning to contribute the changes I came up with here to themI contributed my findings upstream (Fix CI and switch to GitHub Actions hapijs/good#640).Note that the added
.github/workflows/ci-plugin.ymlfile is identical to the one in hapijs#639 with one notable exception: Ours also tests against hapi v18, since we're currently using that in Kibana.