Fix CI and switch to GitHub Actions#640
Merged
Nargonath merged 4 commits intohapijs:masterfrom Dec 2, 2020
Merged
Conversation
cjihrig
approved these changes
Dec 2, 2020
Contributor
cjihrig
left a comment
There was a problem hiding this comment.
LGTM. We are currently in the process of trying to address flaky tests like this across the entire org, and good is scheduled for EOL at the end of the year.
Nargonath
approved these changes
Dec 2, 2020
Member
Nargonath
left a comment
There was a problem hiding this comment.
Thanks @watson for fixing the PR. To be honest, I didn't do it because good will most likely be deprecated by the end of the year but I forgot to close the PR 😅 . Anyway the job is done so there is no reason to refuse it.
Thanks again. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that #639 was opened recently to switch from Travis CI to GitHub Actions. I can see that it's not merged and I assume it's because CI is currently failing. I've looked into it and it seems to be a series of race-conditions which means that under certain constrained environments (especially CI containers), the tests run their assertions before the tested code have completed running. This PR includes everything from #639 + a few fixes to make CI stable by increasing the test-wait-times. This is obviously not a very nice solution, but it's the solution that the current test-suite employs, so without rewriting everything, this is what I came up with.