[8.19](backport #4985) Ensure directory is made within zip artifacts#4987
Merged
[8.19](backport #4985) Ensure directory is made within zip artifacts#4987
Conversation
* Ensure directory is made within zip artifacts * Make test:release extraction stricter (cherry picked from commit 813f39f)
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
ebeahan
approved these changes
May 29, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
.zip artifacts are incorrectly created so not all tools are able to extract them.
How does this PR solve the problem?
Ensure that the distribution folder is created within the artifact
How to test this PR locally
SNAPSHOT=true PLATFORMS=windows/amd64 mage build:release unzip build/distributions/fleet-server-9.1.0-SNAPSHOT-windows-x86_64.zip ```<hr>This is an automatic backport of pull request #4985 done by [Mergify](https://mergify.com).