Ensure directory is made within zip artifacts (#4985)

michel-laterman · web-flow · commit 813f39f8a864 · 2025-05-28T19:40:48.000-05:00
* Ensure directory is made within zip artifacts

* Make test:release extraction stricter
diff --git a/magefile.go b/magefile.go
@@ -791,6 +791,9 @@ func packageWindows(arch string) error {
 	if err != nil {
 		return fmt.Errorf("unable to turn dir stat into header: %w", err)
 	}
+	if !strings.HasSuffix(dirHeader.Name, "/") {
+		dirHeader.Name += "/"
+	}
 	_, err = zw.CreateHeader(dirHeader)
 	if err != nil {
 		return fmt.Errorf("unable to create zip dir: %w", err)
@@ -1421,10 +1424,6 @@ func unzip(sourceFile, destinationDir string) error {
 			return os.MkdirAll(path, f.Mode())
 		}
 
-		if err = os.MkdirAll(filepath.Dir(path), 0o755); err != nil {
-			return err
-		}
-
 		out, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, f.Mode())
 		if err != nil {
 			return err
