Skip to content

[Flyout System] Add data-test-subj to flyout menu elements#9400

Merged
angeles-mb merged 2 commits intoelastic:mainfrom
angeles-mb:2882-add-data-test-subj-to-flyout-menu-items
Feb 20, 2026
Merged

[Flyout System] Add data-test-subj to flyout menu elements#9400
angeles-mb merged 2 commits intoelastic:mainfrom
angeles-mb:2882-add-data-test-subj-to-flyout-menu-items

Conversation

@angeles-mb
Copy link
Copy Markdown
Contributor

@angeles-mb angeles-mb commented Feb 20, 2026

Summary

  • Added data-test-subj to flyout menu elements: back button, history dropdown button and history items.

Why are we making this change?

Screenshots #

Verified in Storybook identifiers are properly attached to the elements:

Screenshot 2026-02-20 at 11 56 37 Screenshot 2026-02-20 at 11 58 08

Steps for testing this:

EuiFlyout > Manager > Multi-session example > Open a few Sessions so you can see the back and history dropdown.

If needed to be tested in Kibana:

  • Create a build of EUI with this branch
  • Run kibana with yarn start --run-examples
  • Test the System flyouts in the Flyout System Example

Impact to users

No impact. Implementation detail.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
    • If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@angeles-mb angeles-mb self-assigned this Feb 20, 2026
@angeles-mb angeles-mb added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Feb 20, 2026
@angeles-mb angeles-mb marked this pull request as ready for review February 20, 2026 11:43
@angeles-mb angeles-mb requested a review from a team as a code owner February 20, 2026 11:43
@angeles-mb angeles-mb removed the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Feb 20, 2026
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🟢

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

cc @angeles-mb

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

cc @angeles-mb

@angeles-mb angeles-mb merged commit 52b27ae into elastic:main Feb 20, 2026
6 checks passed
acstll added a commit to elastic/kibana that referenced this pull request Feb 25, 2026
## Dependency updates

- `@elastic/eui` - v113.0.0 ⏩ v113.1.0
- `@elastic/eui-theme-borealis` - v6.0.0 ⏩ v6.1.0

---

## Changes

| Commit | Change | Teams (Code Owner) |
| :--- | :--- | :--- |
| 18ef117 | Update snapshots, new Assistance color tokens
([#9383](elastic/eui#9383)) |
@elastic/kibana-security |
| 3fad87f | Update snapshots, new `aria-expanded` attribute added to
button triggers of `EuiPopover`
([#9381](elastic/eui#9381)) |
@elastic/appex-sharedux, @elastic/kibana-visualizations,
@elastic/kibana-data-discovery |
| cc9e096 | Update snapshots, remove
`aria-controls` now handled by `EuiPopover` directly
([#9381](elastic/eui#9381)) |
@elastic/kibana-security |

## Package updates

### `@elastic/eui`
[v113.1.0](https://github.com/elastic/eui/releases/tag/v113.1.0)

- Added `data-test-subj` attributes to `EuiFlyoutMenu` elements: back
button, history dropdown, and history items.
([#9400](elastic/eui#9400))
- Added new assistance tokens:
([#9383](elastic/eui#9383))
    - `euiTheme.colors.backgroundFilledAssistance`
    - `euiTheme.colors.backgroundLightAssistance`
    - `euiTheme.colors.backgroundBaseAssistance`
    - `euiTheme.components.buttons.backgroundAssistanceHover`,
    - `euiTheme.components.buttons.backgroundFilledAssistanceHover`
    - `euiTheme.colors.backgroundBaseInteractiveHoverAssistance`
    - `euiTheme.colors.borderStrongAssistance`
    - `euiTheme.colors.borderBaseAssistance`
    - `euiTheme.colors.textAssistance`
    - `euiTheme.colors.vis.euiColorVisAssistance`
    - `euiTheme.colors.severity.assistance`
    - `euiTheme.colors.vis.euiColorVis10`
    - `euiTheme.colors.vis.euiColorVis11`
    - `euiTheme.colors.vis.euiColorVisText10`
    - `euiTheme.colors.vis.euiColorVisText11`
- Updated purple color palette shades 30-60 to slightly lighter values
([#9383](elastic/eui#9383))

**Accessibility**

- Adds `aria-expanded` and `aria-controls` to the `EuiPopover` trigger
button to improve screen reader context
([#9381](elastic/eui#9381))

### `@elastic/eui-theme-borealis` v6.1.0

- Added new assistance tokens:
([#9383](elastic/eui#9383))
    - `euiTheme.colors.backgroundFilledAssistance`
    - `euiTheme.colors.backgroundLightAssistance`
    - `euiTheme.colors.backgroundBaseAssistance`
    - `euiTheme.components.buttons.backgroundAssistanceHover`,
    - `euiTheme.components.buttons.backgroundFilledAssistanceHover`
    - `euiTheme.colors.backgroundBaseInteractiveHoverAssistance`
    - `euiTheme.colors.borderStrongAssistance`
    - `euiTheme.colors.borderBaseAssistance`
    - `euiTheme.colors.textAssistance`
    - `euiTheme.colors.vis.euiColorVisAssistance`
    - `euiTheme.colors.severity.assistance`
    - `euiTheme.colors.vis.euiColorVis10`
    - `euiTheme.colors.vis.euiColorVis11`
    - `euiTheme.colors.vis.euiColorVisText10`
    - `euiTheme.colors.vis.euiColorVisText11`
- Updated purple color palette shades 30-60 to slightly lighter values
([#9383](elastic/eui#9383))
qn895 pushed a commit to qn895/kibana that referenced this pull request Mar 11, 2026
## Dependency updates

- `@elastic/eui` - v113.0.0 ⏩ v113.1.0
- `@elastic/eui-theme-borealis` - v6.0.0 ⏩ v6.1.0

---

## Changes

| Commit | Change | Teams (Code Owner) |
| :--- | :--- | :--- |
| 18ef117 | Update snapshots, new Assistance color tokens
([elastic#9383](elastic/eui#9383)) |
@elastic/kibana-security |
| 3fad87f | Update snapshots, new `aria-expanded` attribute added to
button triggers of `EuiPopover`
([elastic#9381](elastic/eui#9381)) |
@elastic/appex-sharedux, @elastic/kibana-visualizations,
@elastic/kibana-data-discovery |
| cc9e096 | Update snapshots, remove
`aria-controls` now handled by `EuiPopover` directly
([elastic#9381](elastic/eui#9381)) |
@elastic/kibana-security |

## Package updates

### `@elastic/eui`
[v113.1.0](https://github.com/elastic/eui/releases/tag/v113.1.0)

- Added `data-test-subj` attributes to `EuiFlyoutMenu` elements: back
button, history dropdown, and history items.
([elastic#9400](elastic/eui#9400))
- Added new assistance tokens:
([elastic#9383](elastic/eui#9383))
    - `euiTheme.colors.backgroundFilledAssistance`
    - `euiTheme.colors.backgroundLightAssistance`
    - `euiTheme.colors.backgroundBaseAssistance`
    - `euiTheme.components.buttons.backgroundAssistanceHover`,
    - `euiTheme.components.buttons.backgroundFilledAssistanceHover`
    - `euiTheme.colors.backgroundBaseInteractiveHoverAssistance`
    - `euiTheme.colors.borderStrongAssistance`
    - `euiTheme.colors.borderBaseAssistance`
    - `euiTheme.colors.textAssistance`
    - `euiTheme.colors.vis.euiColorVisAssistance`
    - `euiTheme.colors.severity.assistance`
    - `euiTheme.colors.vis.euiColorVis10`
    - `euiTheme.colors.vis.euiColorVis11`
    - `euiTheme.colors.vis.euiColorVisText10`
    - `euiTheme.colors.vis.euiColorVisText11`
- Updated purple color palette shades 30-60 to slightly lighter values
([elastic#9383](elastic/eui#9383))

**Accessibility**

- Adds `aria-expanded` and `aria-controls` to the `EuiPopover` trigger
button to improve screen reader context
([elastic#9381](elastic/eui#9381))

### `@elastic/eui-theme-borealis` v6.1.0

- Added new assistance tokens:
([elastic#9383](elastic/eui#9383))
    - `euiTheme.colors.backgroundFilledAssistance`
    - `euiTheme.colors.backgroundLightAssistance`
    - `euiTheme.colors.backgroundBaseAssistance`
    - `euiTheme.components.buttons.backgroundAssistanceHover`,
    - `euiTheme.components.buttons.backgroundFilledAssistanceHover`
    - `euiTheme.colors.backgroundBaseInteractiveHoverAssistance`
    - `euiTheme.colors.borderStrongAssistance`
    - `euiTheme.colors.borderBaseAssistance`
    - `euiTheme.colors.textAssistance`
    - `euiTheme.colors.vis.euiColorVisAssistance`
    - `euiTheme.colors.severity.assistance`
    - `euiTheme.colors.vis.euiColorVis10`
    - `euiTheme.colors.vis.euiColorVis11`
    - `euiTheme.colors.vis.euiColorVisText10`
    - `euiTheme.colors.vis.euiColorVisText11`
- Updated purple color palette shades 30-60 to slightly lighter values
([elastic#9383](elastic/eui#9383))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants