Fix EuiFlyout z-index values for managed and unmanaged flyouts#9169
Merged
tkajtoch merged 4 commits intoelastic:mainfrom Nov 4, 2025
Merged
Fix EuiFlyout z-index values for managed and unmanaged flyouts#9169tkajtoch merged 4 commits intoelastic:mainfrom
z-index values for managed and unmanaged flyouts#9169tkajtoch merged 4 commits intoelastic:mainfrom
Conversation
…nd `maskProps` combinations
tkajtoch
commented
Nov 4, 2025
| ...dynamicStyles, | ||
| ...minWidthOverride, | ||
| ...(finalMaxWidth ? { maxWidth: finalMaxWidth } : {}), | ||
| zIndex, |
Member
Author
There was a problem hiding this comment.
z-index is now defined inside the inline style tag. It'll become dynamic in #9160, so I thought it's best if I structure the code in a way that makes that work a little simpler.
tkajtoch
commented
Nov 4, 2025
| }; | ||
|
|
||
| /** | ||
| * TODO: Calculate z-index values so that the latest flyout is always on top |
Member
Author
There was a problem hiding this comment.
This is to be addressed in a separate PR
Collaborator
💚 Build SucceededHistory
cc @tkajtoch |
Collaborator
💚 Build Succeeded
cc @tkajtoch |
tsullivan
approved these changes
Nov 4, 2025
tkajtoch
added a commit
to tkajtoch/eui
that referenced
this pull request
Nov 4, 2025
…uts (elastic#9169)" This reverts commit 3680ae4.
tsullivan
pushed a commit
to tsullivan/eui
that referenced
this pull request
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #9141
This PR fixes the issue with
z-indexvalues of EuiFlyout's overlay mask.When I initially refactored the EuiOverlayMask rendering logic in EuiFlyout I forgot to pass
headerZindexLocation="below"which was there before. This was impossible to notice when testing in Storybook, and hid almost perfectly when testing builds if the flyout system branch in Kibana. I noticed it by accident when testing different flyout combinations, but it was also reported during other people's testing - see the linked issue above.This PR brings back the rarely (never?) used z-index of 6000 for 100% compatibility with previous versions of EUI. Furthermore, the added internal hook is a prep work for intelligent z-index management needed to f i x #9160.
I'm skipping the changelog on this one since this bug shouldn't exist in the first place, and it was never released to the public. The upcoming changelogs describe the correct (after this fix) behavior well enough.
Why are we making this change?
To fix buggy behavior introduced in recent changes to EuiFlyout and the flyout system.
Impact to users
No negative impact to users. This isn't a breaking change.
QA
gh pr checkout 241722yarn kbn bootstrapTest if flyouts and their overlay masks look as expected, specifically these variants:
General checklist