[Visual Refresh] Remove legacy Amsterdam theme by mgadewoll · Pull Request #9090 · elastic/eui

mgadewoll · 2025-10-10T16:06:10Z

Summary

This PR removes all code related to the legacy "Amsterdam" theme as well as conditional theme specific code.

Additional changes

removes obsolete SCSS files
removes the theme switcher in the EUI docs and adds a "high contrast mode" toggle instead

default	enabled

Why are we making this change?

🧹 ✨ Maintainability: Removing the legacy "Amsterdam" theme to simplify the UI update workflow and reduce the "dead" code weight.

Screenshots #

Impact to users

🔴 This is a breaking change due to the removal of theme tokens and package files.
Consumers that rely on imports from /src/themes or SCSS files from src/global_styling/mixins as well as consumers using EuiThemeAmsterdam or euiTheme.flags need to update their code.

ℹ️ The required changes for Kibana have been prepared here.

QA

verify there is no "Amsterdam" related code in eui anymore
ensure eui, eui-theme-borealis and eui-theme-common packages build correctly
smoke test button and form components to verify there was no regression during the removal (running VRT is useful here)
verify the added high contrast mode switcher in the EUI docs works correctly

Consumer updates

ℹ️ No action required here. Adding the consumer updates for tracking purposes.

update Kibana to remove Amsterdam related code and verify CI doesn't fail (requires updates due to removed Amsterdam theme -> done here)
update Cloud-UI to remove Amsterdam related code and verify CI doesn't fail: https://github.com/elastic/cloud-ui/pull/565

General checklist

Browser QA
- Checked in both light and dark modes
- Checked in both MacOS and Windows high contrast modes
  - (emulate forced colors if you do not have access to a Windows machine.)
- Checked in mobile
- Checked in Chrome, Safari, Edge, and Firefox
- Checked for accessibility including keyboard-only and screenreader modes
Docs site QA
- Added documentation
- Props have proper autodocs (using @default if default values are missing) and playground toggles
- Checked Code Sandbox works for any docs examples
Code quality checklist
- Added or updated jest and cypress tests
- Updated visual regression tests
Release checklist
- A changelog entry exists and is marked appropriately.
- If applicable, added the breaking change issue label (and filled out the breaking change checklist)
Designer checklist
- If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

github-actions · 2025-10-10T16:06:27Z

This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:

If this PR contains prop/API changes:
- Search through Kibana for <EuiComponent usages (example search)
- In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)
If this PR contains CSS changes:
- Search through Kibana for the changed EUI selectors, e.g. .euiComponent (example search)
- In the PR description or in a PR comment, include a count or list with the number of custom CSS overrides in Kibana that will need to be updated (if that amount is "none", include that information as well)
🔍 Tip: When searching through Kibana, consider excluding **/target, **/*.snap, **/*.storyshot files to reduce noise and only look at source code usages
⚠️ For extremely risky changes, the EUI team should potentially consider the following precautions:
- Using a pre-release release candidate to test Kibana CI ahead of time
- Using kibana-a-la-carte for manual QA, and to give other Kibana teams a staging server to quickly test against

Log | Bot Usage

there are no JSON export files required to be copied anymore

- due to buttonVariant refactoring

- expected change (fix); the previous toggleTypeStyle wasn't applied correctly due to the nested object returned from euiFilterButtonDisplay

- due to formVariant refactoring

- removes global_styling SCSS files as they are located in eui-theme-common - removes component specific SCSS mixin files as those styles are not used within EUI anymore and the styles were not updated either

mgadewoll · 2025-10-27T07:27:59Z

ℹ️ Rebased with latest main.

weronikaolejniczak · 2025-10-27T09:05:34Z

Testing:

✅ yarn && yarn workspace @elastic/eui build:workspaces
✅ yarn workspace @elastic/eui build
✅ Jest tests pass locally
❌ VRT tests don't pass locally
✅ Cypress tests pass locally
✅ yarn workspace @elastic/eui start (Storybook)
✅ smoke tested the majority of components, including forms and buttons
✅ HCM switcher works correctly
✅ CI passes

Details

Website:

Jest:

Cypress:

VRT:

What failed specifically:

Code review: in progress...

Will take a look at the Kibana PR and Cloud PR as a sanity check as well.

packages/docusaurus-theme/src/theme/EditThisPage/index.tsx

packages/eui-theme-borealis/.stylelintrc.js

packages/eui/.loki/reference/chrome_desktop_Forms_EuiFilterButton_Full_Width_And_Grow.png

weronikaolejniczak · 2025-10-27T09:22:00Z

packages/eui/src/services/theme/provider.tsx

    if (!isParentTheme.current) {
      /* Enables recomputation of component colors when flags are overridden on the provider
      by adding the respective key to modifications to trigger a recomputation. */
+      // NOTE: Keeping this as placeholder for potential future usage during Borealis changes


Makes sense to me 👍🏻 good decision

packages/website/docs/getting-started/theming/tokens/colors/index.mdx

weronikaolejniczak · 2025-10-27T09:25:28Z

Code review:

I shared some doubts I have but none of them are blocking. I also confirm there's nothing in the codebase that refers to "Amsterdam" theme (other than changelogs ofc):

Before approving, I'll also go through the touched components again to verify there's no regression from production (although functional and VRT tests passing should give enough confidence).

weronikaolejniczak

Components:

✅ EuiBetaBadge
✅ EuiNotificationBadge
✅ EuiButton
✅ EuiButtonEmpty
✅ EuiButtonGroup
✅ EuiButtonIcon
✅ EuiCollapsibleNavBeta
✅ EuiComboBox
✅ EuiDataGrid
✅ EuiSuperDatePicker
✅ EuiFilterGroup
✅ EuiFieldNumber
✅ EuiFieldText
✅ EuiFilePicker
✅ EuiFormControlLayout
✅ EuiFormErrorText
✅ EuiFormLabel
✅ EuiRange
✅ EuiHeader
✅ EuiKeyPadMenu
✅ EuiMarkdownEditor
✅ EuiPanel
✅ EuiResizableContainer
✅ EuiSearchBar
✅ EuiSelectableTemplateSitewide
✅ EuiToast
✅ EuiToken

LGTM! 🟢 Thank you for the diligence and all the hard work, Lene 🙏🏻 Removing Amsterdam stuff must've felt good!

elasticmachine · 2025-10-27T11:56:46Z

💚 Build Succeeded

History

💚 Build #1694 succeeded 07ce781
💚 Build #1577 succeeded ce15e47
💚 Build #1540 succeeded d6b4290
💚 Build #1505 succeeded db1704c
💚 Build #1504 succeeded 28ce7c8
💔 Build #1490 failed 43958de

cc @mgadewoll

elasticmachine · 2025-10-27T12:09:52Z

💚 Build Succeeded

Buildkite Build
Commit: fefa005

History

💚 Build #5032 succeeded 07ce781
💚 Build #4948 succeeded ce15e47
💚 Build #4924 succeeded d6b4290
💚 Build #4898 succeeded db1704c
💚 Build #4885 succeeded 43958de

cc @mgadewoll

- `@elastic/eui`: `v107.0.1` ⏩ `v108.0.0` - `@elastic/eui-theme-borealis`: `v3.6.0` ⏩ `v4.0.0` --- ## Changes >[!IMPORTANT] This PR removes code related to the legacy Amsterdam theme. But it purposefully keeps Amsterdam palettes in `kbn-palettes` as those are standalone. - removed code related to the legacy theme Amsterdam [[#9090](elastic/eui#9090)] - updated custom types to align with changes to the event type of `onClose` on `EuiModal` [[#9137](elastic/eui#9137)] ## Package updates ### [`v108.0.0`](https://github.com/elastic/eui/releases/v108.0.0) - Updated `EuiModal` to support closing on outside click, via the new `outsideClickCloses` prop ([#9137](elastic/eui#9137)) **Breaking changes** - Removed all "Amsterdam" theme related code in `src/themes/amsterdam` - EUI now only supports the "Borealis" theme in `eui-theme-borealis` ([#9090](elastic/eui#9090)) - Removed `euiTheme.flags.hasGlobalFocusColor` ([#9090](elastic/eui#9090)) - Removed `euiTheme.flags.hasVisColorAdjustment` ([#9090](elastic/eui#9090)) - Removed `hasVisColorAdjustment` argument from color palettes (used in `euiPaletteColorBlindBehindText`, `euiPaletteForTemperature`, `euiPaletteComplementary`, `euiPaletteCool`) ([#9090](elastic/eui#9090)) - Removed `euiTheme.flags.buttonVariant` and `euiTheme.flags.formVariant` ([#9090](elastic/eui#9090)) - Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect` ([#9090](elastic/eui#9090)) - Removed legacy SCSS files from `src/global_styling/variables`, `src/global_styling/mixins` and `src/global_styling/functions` - if needed, use them from `eui-theme-common` instead ([#9090](elastic/eui#9090)) ### [`v4.0.0`](https://github.com/elastic/eui/releases/v4.0.0) **Breaking changes** - Removed `euiTheme.flags.hasGlobalFocusColor` ([#9090](elastic/eui#9090)) - Removed `euiTheme.flags.hasVisColorAdjustment` ([#9090](elastic/eui#9090)) - Removed `euiTheme.flags.buttonVariant` and `euiTheme.flags.formVariant` ([#9090](elastic/eui#9090)) - Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect` ([#9090](elastic/eui#9090)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

- `@elastic/eui`: `v107.0.1` ⏩ `v108.0.0` - `@elastic/eui-theme-borealis`: `v3.6.0` ⏩ `v4.0.0` --- ## Changes >[!IMPORTANT] This PR removes code related to the legacy Amsterdam theme. But it purposefully keeps Amsterdam palettes in `kbn-palettes` as those are standalone. - removed code related to the legacy theme Amsterdam [[elastic#9090](elastic/eui#9090)] - updated custom types to align with changes to the event type of `onClose` on `EuiModal` [[elastic#9137](elastic/eui#9137)] ## Package updates ### [`v108.0.0`](https://github.com/elastic/eui/releases/v108.0.0) - Updated `EuiModal` to support closing on outside click, via the new `outsideClickCloses` prop ([elastic#9137](elastic/eui#9137)) **Breaking changes** - Removed all "Amsterdam" theme related code in `src/themes/amsterdam` - EUI now only supports the "Borealis" theme in `eui-theme-borealis` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.hasGlobalFocusColor` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.hasVisColorAdjustment` ([elastic#9090](elastic/eui#9090)) - Removed `hasVisColorAdjustment` argument from color palettes (used in `euiPaletteColorBlindBehindText`, `euiPaletteForTemperature`, `euiPaletteComplementary`, `euiPaletteCool`) ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.buttonVariant` and `euiTheme.flags.formVariant` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect` ([elastic#9090](elastic/eui#9090)) - Removed legacy SCSS files from `src/global_styling/variables`, `src/global_styling/mixins` and `src/global_styling/functions` - if needed, use them from `eui-theme-common` instead ([elastic#9090](elastic/eui#9090)) ### [`v4.0.0`](https://github.com/elastic/eui/releases/v4.0.0) **Breaking changes** - Removed `euiTheme.flags.hasGlobalFocusColor` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.hasVisColorAdjustment` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.buttonVariant` and `euiTheme.flags.formVariant` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect` ([elastic#9090](elastic/eui#9090)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

mgadewoll self-assigned this Oct 10, 2025

mgadewoll added breaking change PRs with breaking changes. (Don't delete - used for automation) visual refresh labels Oct 10, 2025

mgadewoll force-pushed the theme/remove-amsterdam branch from 43958de to 28ce7c8 Compare October 13, 2025 08:02

mgadewoll mentioned this pull request Oct 13, 2025

[Theme] Remove duplicate Borealis JSON export files #9066

Closed

13 tasks

mgadewoll force-pushed the theme/remove-amsterdam branch from db1704c to d6b4290 Compare October 15, 2025 09:38

mgadewoll marked this pull request as ready for review October 15, 2025 14:11

mgadewoll requested a review from a team as a code owner October 15, 2025 14:11

mgadewoll force-pushed the theme/remove-amsterdam branch from d6b4290 to ce15e47 Compare October 16, 2025 08:05

mgadewoll added 19 commits October 27, 2025 08:23

refactor: remove Amsterdam theme

181381a

refactor: update direct imports from removed themes folder

fd6ff58

build: remove copyFiles script

21454ec

there are no JSON export files required to be copied anymore

docs: remove theme selection from storybook and website

53eda5c

chore: add missing selected styles

0bc6c5e

refactor: remove hasGlobalFocusColor theme flag

affc3ff

refactor: remove hasVisColorAdjustment theme flag and resolve usages

9661d85

refactor: remove buttonVariant theme flag and resolve usages

fcffdcc

test: update snapshots

193ba44

- due to buttonVariant refactoring

test(vrt): update reference images

9bdf908

- expected change (fix); the previous toggleTypeStyle wasn't applied correctly due to the nested object returned from euiFilterButtonDisplay

refactor: remove formVariant theme flag and resolve usages

5de0bf9

test: update snapshots

a168642

- due to formVariant refactoring

chore: cleanup links and comments

81300ab

docs: remove Amsterdam specific output

84874ef

refactor: remove obsolte scss fils

593cab6

- removes global_styling SCSS files as they are located in eui-theme-common - removes component specific SCSS mixin files as those styles are not used within EUI anymore and the styles were not updated either

chore: add changelogs

349d895

chore: cleanup shadow updates after rebase

f1850db

refactor: remove obsolete conditions in euiPanelBorderStyles

cd542d0

chore: remove Amsterdam related comments

07ce781

mgadewoll force-pushed the theme/remove-amsterdam branch from ce15e47 to 07ce781 Compare October 27, 2025 07:27

weronikaolejniczak reviewed Oct 27, 2025

View reviewed changes

packages/docusaurus-theme/src/theme/EditThisPage/index.tsx Outdated Show resolved Hide resolved

weronikaolejniczak reviewed Oct 27, 2025

View reviewed changes

packages/eui-theme-borealis/.stylelintrc.js Show resolved Hide resolved

weronikaolejniczak reviewed Oct 27, 2025

View reviewed changes

packages/eui/.loki/reference/chrome_desktop_Forms_EuiFilterButton_Full_Width_And_Grow.png Show resolved Hide resolved

weronikaolejniczak reviewed Oct 27, 2025

View reviewed changes

packages/website/docs/getting-started/theming/tokens/colors/index.mdx Outdated Show resolved Hide resolved

weronikaolejniczak approved these changes Oct 27, 2025

View reviewed changes

mgadewoll added 3 commits October 27, 2025 11:52

chore: remove obsolete space

e49f4a6

refactor: use regular eui import path

7386269

chore: add docusaurus-theme changelog

fefa005

mgadewoll merged commit ffeba48 into elastic:main Oct 27, 2025
9 checks passed

mgadewoll mentioned this pull request Oct 27, 2025

Update EUI to v108.0.0 elastic/kibana#240888

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Visual Refresh] Remove legacy Amsterdam theme#9090

[Visual Refresh] Remove legacy Amsterdam theme#9090
mgadewoll merged 22 commits intoelastic:mainfrom
mgadewoll:theme/remove-amsterdam

mgadewoll commented Oct 10, 2025 •

edited by weronikaolejniczak

Loading

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

mgadewoll commented Oct 27, 2025

Uh oh!

weronikaolejniczak commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weronikaolejniczak Oct 27, 2025

Uh oh!

Uh oh!

weronikaolejniczak commented Oct 27, 2025

Uh oh!

weronikaolejniczak left a comment

Uh oh!

elasticmachine commented Oct 27, 2025

Uh oh!

elasticmachine commented Oct 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mgadewoll commented Oct 10, 2025 • edited by weronikaolejniczak Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Additional changes

Why are we making this change?

Screenshots #

Impact to users

QA

General checklist

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

mgadewoll commented Oct 27, 2025

Uh oh!

weronikaolejniczak commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weronikaolejniczak Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

weronikaolejniczak commented Oct 27, 2025

Uh oh!

weronikaolejniczak left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 27, 2025

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Oct 27, 2025

💚 Build Succeeded

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mgadewoll commented Oct 10, 2025 •

edited by weronikaolejniczak

Loading