[Flyout System] Automatic aria-labelledby referencing the EuiFlyoutMenu title ID#9073
Merged
tsullivan merged 3 commits intoelastic:feat/flyout-systemfrom Oct 3, 2025
Conversation
dfe5e4c to
717c0fe
Compare
Collaborator
💚 Build SucceededHistory
|
Collaborator
💚 Build Succeeded
History
|
tkajtoch
approved these changes
Oct 3, 2025
Member
tkajtoch
left a comment
There was a problem hiding this comment.
Changes look good and work as expected. Thank you for making the developer experience better!
Member
Author
|
@clintandrewhall mentioned an enhancement on top could be to eliminate the need for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements automatic ARIA labeling for flyouts with menus.
Why are we making this change?
aria-labelledbyvalue to their flyout, or a customtitleIdvalue inflyoutMenuPropsif needed.Impact to users
Existing flyouts continue to work without code changes.
Developers that migrate EuiFlyout instances to use the
session=trueprop will not have to do extra work to carry over proper ARIA labeling.Consider the following diff. The "before" code manually constructs an ARIA label relationship between the
EuiFlyoutcomponent and theh2. In the "after" code, that manual construction is not necessary, as the flyout title is taken fromflyoutMenuProps. The changes in this PR ensure that the correct ARIA label relationship happens automatically.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles