Skip to content

fix(EuiMarkdownFormat): Render unknown code block languages as plain text#8729

Merged
tkajtoch merged 2 commits intoelastic:mainfrom
tkajtoch:fix/eui-markdown-format-unknown-languages
Jun 2, 2025
Merged

fix(EuiMarkdownFormat): Render unknown code block languages as plain text#8729
tkajtoch merged 2 commits intoelastic:mainfrom
tkajtoch:fix/eui-markdown-format-unknown-languages

Conversation

@tkajtoch
Copy link
Copy Markdown
Member

@tkajtoch tkajtoch commented Jun 2, 2025

Fixes #8728

Summary

This fixes an issue in EuiMarkdownFormat, causing the component to render markdown content as plain text when an unregistered language is passed to a fenced code block.

QA

  1. Open EuiMarkdownFormat docs page
  2. Edit the example code so that markdownContent variable is set to:
    const markdownContent = `
    # Hello, World!
    ~~~blah
    console.log(123);
    ~~~
    `
  3. Confirm the heading and code block are rendered correctly. The code block should be rendered as plain text since the blah language is not registered.

General checklist

  • Release checklist
    • A changelog entry exists and is marked appropriately.

@tkajtoch tkajtoch self-assigned this Jun 2, 2025
@tkajtoch tkajtoch marked this pull request as ready for review June 2, 2025 09:46
@tkajtoch tkajtoch requested a review from a team as a code owner June 2, 2025 09:46
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

cc @tkajtoch

@weronikaolejniczak weronikaolejniczak self-requested a review June 2, 2025 10:02
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, it's looking good 👌🏻 console.log renders as plain text, no syntax highlighting

Screenshot 2025-06-02 at 12 04 20

@tkajtoch tkajtoch enabled auto-merge (squash) June 2, 2025 10:06
@tkajtoch tkajtoch merged commit 506794b into elastic:main Jun 2, 2025
6 checks passed
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

cc @tkajtoch

JasonStoltz added a commit to elastic/kibana that referenced this pull request Jun 17, 2025
`102.3.0` ⏩ `103.0.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Changes

[#8736](elastic/eui#8736),
[#8732](elastic/eui#8732), and
[#8732](elastic/eui#8732) include a number of
small style tweaks `EuiResizableCollapseButton`, `EuiTitle`, and
`EuiListGroupItem`.

[#8756](elastic/eui#8756) and
[#8744](elastic/eui#8744) rename a couple of
icons:

`questionInCircle` -> `question`
`iInCircle` > `info`

In both cases, the old name is **backwards-compatible** (unless
importing directly from `assets` folder (see more in the release notes
regarding that). However, the old name will eventually be deprecated as
a part of a larger set of deprecations.

**No action is required at this time to handle this renaming. We will
issue a dedicated PR to Kibana to replace the old names with the new
names in the future**

[#8725](elastic/eui#8725) adds Sky Blue, Yellow,
and Orange palettes to EUI's [color
palettes](https://eui.elastic.co/docs/utilities/color-palettes/#recommended-quantitative-palettes),
as well as new tokens for Risk, Neutral, and Warning.

**[Breaking change]** Please note that as part of this change, the
following tokens have been renamed:
`euiColorVisNeutral0` -> `euiColorVisBase0`
`euiColorVisWarning0` -> `euiColorVisWarning1`

The original tokens still exist, but have been updated to use new colors
in a way that would be breaking. This PR updates the existing references
in 0b21d2d.

## Package updates

### `@elastic/eui`

## [`v103.0.0`](https://github.com/elastic/eui/releases/v103.0.0)

- Replaced `question` icon glyph
([#8756](elastic/eui#8756))
- Updated `EuiResizableCollapseButton` to use an empty button
([#8736](elastic/eui#8736))
- Added `info` icon glyph
([#8744](elastic/eui#8744))
- Removed uppercase styling from `EuiText` `h6` headings to match
`EuiTitle` ([#8732](elastic/eui#8732))
- Removed heavier font weight from `xs` and `s` `EuiListGroupItem` sizes
for consistency ([#8732](elastic/eui#8732))
- Updated the `font-weight` of default `EuiFilterButton` and
`EuiButtonGroupButton` to `450`
([#8734](elastic/eui#8734))
- Added color pallete functions and related hooks:
([#8725](elastic/eui#8725))
  - `euiPaletteSkyBlue`, `useEuiPaletteSkyBlue`
  - `euiPaletteYellow`, `useEuiPaletteYellow`
  - `euiPaletteOrange`, `useEuiPaletteOrange`
- Added new tokens on `colors.vis`:
([#8725](elastic/eui#8725))
  -  `euiColorVisNeutral0`
  -  `euiColorVisNeutral1`
  -  `euiColorVisWarning1`
  -  `euiColorVisRisk0`
  -  `euiColorVisRisk1`
- Updated the value of token `colors.vis.euiColorVisWarning0`
([#8725](elastic/eui#8725))
- Updated EuiFilterButton's `numActiveFilters` prop to accept percentage
values ([#8705](elastic/eui#8705))

**Bug fixes**

- Fixed visual positioning issue for notifications in
`EuiHeaderSectionItemButton`
([#8736](elastic/eui#8736))
- Fixed a visual issue where `EuiCollabsibleNavItem` did not have a
visible selected state
([#8736](elastic/eui#8736))
- Fixed handling of unregistered code block languages in
`EuiMarkdownFormat` ([#8729](elastic/eui#8729))

**Breaking changes**

- Renamed `colors.vis.euiColorVisNeutral0` to `euiColorVisBase0`
([#8725](elastic/eui#8725))

### `@elastic/eui-theme-borealis`

##
[`v2.0.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v200)

- Added new tokens on `colors.vis`:
([#8725](elastic/eui#8725))
  -  `euiColorVisNeutral0`
  -  `euiColorVisNeutral1`
  -  `euiColorVisWarning1`
  -  `euiColorVisRisk0`
  -  `euiColorVisRisk1`
- Updated the value of token `colors.vis.euiColorVisWarning0`
([#8725](elastic/eui#8725))

**Bug fixes**

- Fixed missing source map warnings emitted by some bundlers by
excluding source maps from being published
([#8764](elastic/eui#8764))
- To align with `@elastic/eui` and many other popular packages, we made
a call to not ship source maps anymore

**Breaking changes**

- Renamed `colors.vis.euiColorVisNeutral0` to `euiColorVisBase0`
([#8725](elastic/eui#8725))

<!--ONMERGE {"backportTargets":["8.19","9.0"]} ONMERGE-->

---------

Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EuiMarkdownFormat] Passing an unknown language to a code block crashes the Markdown renderer

5 participants