Skip to content

fix(website): examples in Page template section#8542

Merged
acstll merged 4 commits intoelastic:mainfrom
acstll:fix/docs-broken-examples
Apr 4, 2025
Merged

fix(website): examples in Page template section#8542
acstll merged 4 commits intoelastic:mainfrom
acstll:fix/docs-broken-examples

Conversation

@acstll
Copy link
Copy Markdown
Contributor

@acstll acstll commented Apr 3, 2025

Resolves #8164
Resolves #8518

Fixes broken examples for Page template section.

QA

acstll added 3 commits April 3, 2025 14:23
adding a global max-inline-size: 100% for images, should be OK
so it sits above EuiBottomBar, but still below EuiFlyout and co
@acstll acstll added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Apr 3, 2025
@acstll acstll self-assigned this Apr 3, 2025
@acstll acstll marked this pull request as ready for review April 3, 2025 13:23
@acstll acstll requested a review from a team as a code owner April 3, 2025 13:23
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @acstll! I have some doubts but they're quite simple to resolve.

Testing notes

Showing a bottom bar

Blocking:

The "Showing a bottom bar" example (old docs, new docs) is different. There are no controls anymore and there's no sidebar. But the text says:

Adding an EuiBottomBar can be tricky to use and account for any sidebars. EuiPageTemplate handles this nicely by supplying a EuiPageTemplate.BottomBar component for passing the contents of your bottom bar that extends EuiBottomBar.

Old docs New docs
Screenshot 2025-04-04 at 11 01 13 Screenshot 2025-04-04 at 10 59 54

Feels to me like we should bring back the sidebar.

Empty pages or content

Non-blocking:

This example looks a bit off and inconsistent with the rest without the "Page title". I'd bring it back.

Old docs New docs
Screenshot 2025-04-04 at 11 02 56 Screenshot 2025-04-04 at 11 02 51

@acstll
Copy link
Copy Markdown
Contributor Author

acstll commented Apr 4, 2025

I addressed both comments in bf4eff7

definitely better, thank you! 🙏

@kibanamachine
Copy link
Copy Markdown

Preview staging links for this PR:

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

cc @acstll

Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the changes, @acstll

@acstll acstll merged commit ca90ae9 into elastic:main Apr 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EUI+] Fix Page template guidelines images [EUI+] [EuiPageTemplate] The examples are incorrect / broken

4 participants