fix(website): examples in Page template section#8542
Conversation
adding a global max-inline-size: 100% for images, should be OK
so it sits above EuiBottomBar, but still below EuiFlyout and co
There was a problem hiding this comment.
This looks great, @acstll! I have some doubts but they're quite simple to resolve.
Testing notes
Showing a bottom bar
Blocking:
The "Showing a bottom bar" example (old docs, new docs) is different. There are no controls anymore and there's no sidebar. But the text says:
Adding an EuiBottomBar can be tricky to use and account for any sidebars. EuiPageTemplate handles this nicely by supplying a EuiPageTemplate.BottomBar component for passing the contents of your bottom bar that extends EuiBottomBar.
| Old docs | New docs |
|---|---|
![]() |
![]() |
Feels to me like we should bring back the sidebar.
Empty pages or content
Non-blocking:
This example looks a bit off and inconsistent with the rest without the "Page title". I'd bring it back.
| Old docs | New docs |
|---|---|
![]() |
![]() |
|
I addressed both comments in bf4eff7 definitely better, thank you! 🙏 |
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @acstll |
weronikaolejniczak
left a comment
There was a problem hiding this comment.
Looks good! Thank you for the changes, @acstll




Resolves #8164
Resolves #8518
Fixes broken examples for Page template section.
QA