docs(EuiEmptyPrompt): Fix missing icons in EUI+ docs#8488
Merged
tkajtoch merged 2 commits intoelastic:mainfrom Mar 25, 2025
Merged
docs(EuiEmptyPrompt): Fix missing icons in EUI+ docs#8488tkajtoch merged 2 commits intoelastic:mainfrom
tkajtoch merged 2 commits intoelastic:mainfrom
Conversation
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
|
Contributor
|
@tkajtoch there's a reference error:
|
Member
Author
|
@weronikaolejniczak I know, I mentioned it in the description. |
Contributor
|
@tkajtoch ah, I'm sorry, I read the description but didn't connect those two. Let me checkout the branch and test locally then 😄 |
weronikaolejniczak
approved these changes
Mar 25, 2025
Contributor
weronikaolejniczak
left a comment
There was a problem hiding this comment.
LGTM! 🎉 Thanks for figuring this out, Tomasz!
Screen.Recording.2025-03-25.at.12.07.33.mov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #8312
This fixes icon rendering in EUI+ EuiEmptyPrompt docs. Utilizing both
iconTypeandiconprops felt easiest to achieve what we want.QA
Please note that EuiEmptyPrompt guidelines use
renderToJSXString, which is incompatible with Docusaurus and our Demo component when used in prod builds. Additionally, EuiPageTemplate's sidebar gets rendered incorrectly as reported here. These pages currently work only when running locally, which is unrelated to this PR.gh pr checkout <id> && yarnyarn workspace @elastic/eui-website run build:workspacesyarn workspace @elastic/eui-website run start