[Visual Refresh] Fix strong border token naming#8262
Merged
mgadewoll merged 2 commits intoelastic:eui-theme/borealisfrom Jan 9, 2025
Merged
[Visual Refresh] Fix strong border token naming#8262mgadewoll merged 2 commits intoelastic:eui-theme/borealisfrom
mgadewoll merged 2 commits intoelastic:eui-theme/borealisfrom
Conversation
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
cc @mgadewoll |
weronikaolejniczak
approved these changes
Jan 9, 2025
Contributor
weronikaolejniczak
left a comment
There was a problem hiding this comment.
LGTM 👍🏻
I ran the docs website and verified that the new tokens (euiColorBorderStrongPrimary, euiColorBorderStrongAccent etc are available) both in Borealis and Amsterdam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We noticed that there seems to have been some typos in the
borderStrongSCSS tokens 🫠This causes the variables to not actually be available for use.
Changes
borderStrongtokens for Borealis dark!defaultflag (since we're here 🤷♀️)QA
verify the tokens are available:
$euiColorBorderStrongSuccessin our EUI docs, e.g. inpackages/eui/src-docs/src/views/home/_home.scssto add a background color somewhere