Skip to content

[Visual Refresh] Provide legacy JSON tokens via EUI#8125

Merged
mgadewoll merged 1 commit intoelastic:eui-theme/borealisfrom
mgadewoll:eui-theme/json-theme-loading-workaround
Nov 11, 2024
Merged

[Visual Refresh] Provide legacy JSON tokens via EUI#8125
mgadewoll merged 1 commit intoelastic:eui-theme/borealisfrom
mgadewoll:eui-theme/json-theme-loading-workaround

Conversation

@mgadewoll
Copy link
Copy Markdown
Contributor

@mgadewoll mgadewoll commented Nov 8, 2024

Summary

Important

This update is temporary as it's only a workaround while we're working on finding a proper solution to loading the legacy files in Kibana from the new theme package.

This PR adds the legacy JSON files to the eui package.

QA

  • CI passes
  • verify files are available:
    • checkout this PR: gh pr checkout 8125
    • build the eui package locally: yarn build-pack (in /packages/eui)
    • check the built .tgz package content and verify the added JSON files are available in the dist folder

- this is a temporary workaround while we figure out how to convince Kibana load those files from a standalone package
@mgadewoll mgadewoll added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Nov 8, 2024
@mgadewoll mgadewoll changed the base branch from main to eui-theme/borealis November 8, 2024 17:53
@kibanamachine
Copy link
Copy Markdown

Preview staging links for this PR:

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

@mgadewoll mgadewoll marked this pull request as ready for review November 8, 2024 18:25
@mgadewoll mgadewoll requested a review from a team as a code owner November 8, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) visual refresh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants