[Visual Refresh] Provide legacy JSON theme tokens#8115
Merged
mgadewoll merged 7 commits intoelastic:eui-theme/borealisfrom Nov 7, 2024
Merged
[Visual Refresh] Provide legacy JSON theme tokens#8115mgadewoll merged 7 commits intoelastic:eui-theme/borealisfrom
mgadewoll merged 7 commits intoelastic:eui-theme/borealisfrom
Conversation
tkajtoch
reviewed
Nov 4, 2024
tkajtoch
reviewed
Nov 4, 2024
tkajtoch
requested changes
Nov 4, 2024
Member
tkajtoch
left a comment
There was a problem hiding this comment.
The changes look great, but the Sass token docs seem to be broken now. Could you please take a look?
Contributor
Author
@tkajtoch Could you specific why was broken in your testing? Cause for me it looks to be working as expected 🤔 |
Contributor
Author
tkajtoch
approved these changes
Nov 7, 2024
2 tasks
358d4f3 to
d6ce8e0
Compare
Contributor
Author
|
ℹ️ I rebased this branch with the feature branch it merges to after this PR was merged as there were conflicts. |
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
mgadewoll
added a commit
that referenced
this pull request
Nov 8, 2024
mgadewoll
added a commit
that referenced
this pull request
Nov 13, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Nov 20, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Nov 27, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 16, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 17, 2024
mgadewoll
added a commit
that referenced
this pull request
Jan 7, 2025
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Jan 20, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes https://github.com/elastic/eui-private/issues/138
Important
This PR merges into a feature branch.
This PR adds legacy JSON token files for the new theme.
These files were copied from the current theme and values updated according to the new theme specifications. Additionally tokens for
accentSecondaryhave been added.Note
No other additional tokens were added as these files are only meant to support existing usages and not promote new usages.
QA