[EuiDataGrid] Revert column width changes#8086
Merged
mgadewoll merged 3 commits intoelastic:mainfrom Oct 18, 2024
Merged
Conversation
Closed
2 tasks
cee-chen
approved these changes
Oct 18, 2024
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
We tried! Thanks for testing this Lene!
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
cee-chen
pushed a commit
to elastic/kibana
that referenced
this pull request
Oct 18, 2024
`v97.0.0-backport.0`⏩`v97.2.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.2.0`](https://github.com/elastic/eui/releases/v97.2.0) - Updated `EuiHeaderLinks` with a new `xxs` gutter size ([#8079](elastic/eui#8079)) **Bug fixes** - Reverted an `EuiDataGrid` regression from [#8015](elastic/eui#8015) which prevented overriding column widths via columns's `initialWidth`s ([#8086](elastic/eui#8086)) ## [`v97.1.0`](https://github.com/elastic/eui/releases/v97.1.0) - Added `columnVisibility.canDragAndDropColumns` on `EuiDataGrid` which enables reordering columns via draggable header cells ([#8015](elastic/eui#8015)) - Updated `EuiHeader`s in dark mode to have a visible border-bottom color ([#8070](elastic/eui#8070)) - Added props `minDate` and `maxDate` on `EuiSuperDatePicker` to support restricting date range selections ([#8071](elastic/eui#8071))
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
`v97.0.0-backport.0`⏩`v97.2.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.2.0`](https://github.com/elastic/eui/releases/v97.2.0) - Updated `EuiHeaderLinks` with a new `xxs` gutter size ([elastic#8079](elastic/eui#8079)) **Bug fixes** - Reverted an `EuiDataGrid` regression from [elastic#8015](elastic/eui#8015) which prevented overriding column widths via columns's `initialWidth`s ([elastic#8086](elastic/eui#8086)) ## [`v97.1.0`](https://github.com/elastic/eui/releases/v97.1.0) - Added `columnVisibility.canDragAndDropColumns` on `EuiDataGrid` which enables reordering columns via draggable header cells ([elastic#8015](elastic/eui#8015)) - Updated `EuiHeader`s in dark mode to have a visible border-bottom color ([elastic#8070](elastic/eui#8070)) - Added props `minDate` and `maxDate` on `EuiSuperDatePicker` to support restricting date range selections ([elastic#8071](elastic/eui#8071)) (cherry picked from commit d7c5608)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts changes done in this PR to store column widths after resize. While the change works for uncontrolled
EuiDataGrids, it currently does not allow for controlled usages to override saved widths anymore.This is an issue in Kibana where column widths can be reset.
We decided to revert the change for now and address it separately, as the issue was not specific to the draggable column update but existed before.
QA