[Theme] Base theme setup by mgadewoll · Pull Request #8030 · elastic/eui

mgadewoll · 2024-09-19T12:59:11Z

Summary

closes #124

Important

This PR is currently still in Draft mode, as it needs alignment on some package/dependency specific setups/architectural choices.

📖 See additional information here.

QA

checkout this PR and verify packages build and run as expected:
- /eui: run build:workspaces to build workspace dependencies then check that our common development tools/scripts work as expected
  - Storybook: yarn storybook and yarn build-storybook
  - EUI docs: yarn start and yarn build-docs
- /website: run build:workspaces and then test that EUI+ docs works as expected via yarn start and yarn build

Deployments & theme switcher testing

By default the theme switcher is only enabled for development environments.

Storybook: https://eui.elastic.co/pr_8030/storybook/?path=/story/navigation-euibutton--playground
EUI docs: https://eui.elastic.co/pr_8030/
EUI+: https://eui.elastic.co/pr_8030/new-docs/

- externally created, compiled and imported themes don't pass the class check anymore we can check for the shape additionally

- theme contains only cloned values from current theme

- ensures current state EUI

-removes circle dependency on main eui

build: ensure sass files are added to packed sub packages

mgadewoll · 2024-10-09T06:22:11Z

packages/eui/package.json

  "peerDependencies": {
    "@elastic/datemath": "^5.0.2",
+    "@elastic/eui-theme-borealis": "0.0.1",
+    "@elastic/eui-theme-common": "0.0.1",


ℹ️ The theme-common package is added as peerDependency for now while it's not actually released yet. Once released we should add it as actual dependency.

mgadewoll · 2024-10-09T06:43:05Z

packages/eui/package.json

  ],
  "scripts": {
    "start": "cross-env BABEL_MODULES=false webpack serve --config=src-docs/webpack.config.js",
+    "build:workspaces": "yarn workspaces foreach -Rti --from @elastic/eui-theme-common run build && yarn workspaces foreach -Rti --from @elastic/eui --exclude @elastic/eui --exclude @elastic/eui-theme-common run build",


❓ I'm wondering if we want to move this also to the root of our monorepo to have a global script to run initially similar to yarn, Wdyt?

mgadewoll · 2024-10-09T06:46:28Z

packages/eui-theme-common/package.json

+  "license": "SEE LICENSE IN LICENSE.txt",
+  "scripts": {
+    "build:clean": "rimraf lib/",
+    "build": "yarn build:clean && yarn build:compile && yarn build:compile:cjs && yarn build:types",


ℹ️ Currently there are no watchers setup yet to listen to changes in these standalone packages. That means that - for now - we need to manually update when e.g. running Storybook or docs.
This should be added for devX but is likely going to happen as a follow-up task.

packages/eui-theme-borealis/.eslintcache

elasticmachine · 2024-10-14T16:30:48Z

💔 Build Failed

Buildkite Build
Commit: 033ed1c

Failed CI Steps

🔨 EUI pull request test

History

💚 Build #2878 succeeded 16bb57e
💚 Build #2872 succeeded 2532104
💔 Build #2869 failed ce4e8e1
💚 Build #2847 succeeded e64597a
💚 Build #2838 succeeded 7486e9a

tkajtoch

I reviewed the code again and ran all common scripts locally to ensure they're all working.

As we already discussed, the changes look great! I don't have any objections, especially considering this is going to be merged to a feature branch.

mgadewoll added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Sep 19, 2024

mgadewoll force-pushed the eui-theme/124-add-new-theme branch 2 times, most recently from cd61810 to d19f6c1 Compare September 19, 2024 14:24

elastic deleted a comment from elasticmachine Sep 19, 2024

mgadewoll force-pushed the eui-theme/124-add-new-theme branch 8 times, most recently from ab1ae64 to 1596ae7 Compare September 23, 2024 13:50

mgadewoll force-pushed the eui-theme/124-add-new-theme branch from b81a336 to 7486e9a Compare September 30, 2024 13:20

mgadewoll added 17 commits October 8, 2024 15:45

fix: ensure getComputed resolves Computed objects correctly

31f6316

- externally created, compiled and imported themes don't pass the class check anymore we can check for the shape additionally

feat: setup new theme package

3d80291

- theme contains only cloned values from current theme

feat: add experimental flag

5f0ae6d

feat: add theme switcher to Storybook

c2e5538

feat: udpate theme switcher to eui docs

51b59f1

build: use workspace reference for EUI dependency

0c61e90

- ensures current state EUI

feat: add theme switcher to eui+ docs

13281dc

build: add eui-common internal module package

9cdacbe

build: add eui-theme-base internal module package

5f618e0

refactor: use new module packages in eui package

04eab8c

refactor: use eui-theme-base package in eui-theme-berlin

03b49f3

-removes circle dependency on main eui

build: prevent generating i18ntokens.json when running build locally

8c9ca71

build: add esm and cjs export for common module

89e722c

build: add esm and cjs export for theme-base module

d481fb1

build: add script for building workspace dependencies

08bef3a

refactor: update sass imports

b3e6f41

build: update dependencies

7642450

build: ensure sass files are added to packed sub packages

mgadewoll changed the title ~~[DO NOT MERGE][DRAFT] Base theme setup~~ [Theme] Base theme setup Oct 8, 2024

build: update workspaces script to ensure theme-common builds first

2532104

mgadewoll force-pushed the eui-theme/124-add-new-theme branch from 62ad98d to 2532104 Compare October 8, 2024 17:38

mgadewoll commented Oct 9, 2024

View reviewed changes

mgadewoll mentioned this pull request Oct 9, 2024

[DO NOT MERGE][DRAFT] Theme color setup #8049

Closed

tkajtoch self-requested a review October 9, 2024 13:44

tkajtoch reviewed Oct 9, 2024

View reviewed changes

packages/eui-theme-borealis/.eslintcache Outdated Show resolved Hide resolved

mgadewoll added 3 commits October 9, 2024 16:53

chore: ignore eslint cache file

17179a7

build: add missing dependencies

16bb57e

refactor: udpate sass import order

033ed1c

tkajtoch marked this pull request as ready for review October 22, 2024 14:04

tkajtoch requested a review from a team as a code owner October 22, 2024 14:04

tkajtoch approved these changes Oct 23, 2024

View reviewed changes

mgadewoll merged commit c2cc86c into elastic:eui-theme/borealis Oct 23, 2024

mgadewoll added a commit that referenced this pull request Oct 23, 2024

[Theme] Base theme setup (#8030)

843dc78

tkajtoch pushed a commit that referenced this pull request Oct 31, 2024

[Theme] Base theme setup (#8030)

f2cda37

mgadewoll added a commit that referenced this pull request Nov 8, 2024

[Theme] Base theme setup (#8030)

af09e18

mgadewoll added a commit that referenced this pull request Nov 13, 2024

[Theme] Base theme setup (#8030)

a6748c7

tkajtoch pushed a commit that referenced this pull request Nov 20, 2024

[Theme] Base theme setup (#8030)

f638ab3

tkajtoch pushed a commit that referenced this pull request Nov 27, 2024

[Theme] Base theme setup (#8030)

736d2fa

tkajtoch pushed a commit that referenced this pull request Dec 16, 2024

[Theme] Base theme setup (#8030)

2f783e4

tkajtoch pushed a commit that referenced this pull request Dec 17, 2024

[Theme] Base theme setup (#8030)

1ff189d

mgadewoll added the visual refresh label Dec 17, 2024

mgadewoll added a commit that referenced this pull request Jan 7, 2025

[Theme] Base theme setup (#8030)

99a8d5b

mgadewoll added a commit to mgadewoll/eui that referenced this pull request Jan 20, 2025

[Theme] Base theme setup (elastic#8030)

80891e5

mgadewoll added a commit to mgadewoll/eui that referenced this pull request Jan 20, 2025

[Theme] Base theme setup (elastic#8030)

af81acc

mgadewoll mentioned this pull request Mar 3, 2025

[Visual Refresh] Add Borealis theme #8386

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Theme] Base theme setup#8030

[Theme] Base theme setup#8030
mgadewoll merged 32 commits intoelastic:eui-theme/borealisfrom
mgadewoll:eui-theme/124-add-new-theme

mgadewoll commented Sep 19, 2024 •

edited by tkajtoch

Loading

Uh oh!

mgadewoll Oct 9, 2024

Uh oh!

mgadewoll Oct 9, 2024 •

edited

Loading

Uh oh!

mgadewoll Oct 9, 2024

Uh oh!

Uh oh!

elasticmachine commented Oct 14, 2024 •

edited

Loading

Uh oh!

tkajtoch left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mgadewoll commented Sep 19, 2024 • edited by tkajtoch Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

QA

Deployments & theme switcher testing

Uh oh!

mgadewoll Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

mgadewoll Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgadewoll Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

History

Uh oh!

tkajtoch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mgadewoll commented Sep 19, 2024 •

edited by tkajtoch

Loading

mgadewoll Oct 9, 2024 •

edited

Loading

elasticmachine commented Oct 14, 2024 •

edited

Loading