[Storybook] Add stories for more components (letter T) - Part 3#7745
[Storybook] Add stories for more components (letter T) - Part 3#7745mgadewoll merged 7 commits intoelastic:mainfrom
Conversation
cf80579 to
9941937
Compare
| content: 'tooltip content', | ||
| iconProps: { | ||
| // using autoFocus here as small trick to ensure showing the tooltip on load (e.g. for VRT) | ||
| // TODO: exchange for loki play() interactions once #7735 is merged |
There was a problem hiding this comment.
I think we can replace it with an interaction now :)
There was a problem hiding this comment.
Yes and No 😅
The mentioned PR is merged but we realized there are issues running Loki interactions on the LOKI_SELECTORS.portal (e.g. EuiComboBox VRT also is broken) - I think you mentioned that you wanted to fix this in this PR?
There was a problem hiding this comment.
I updated the comment to the Loki fix PR instead and added the interactions already but commented out. (commit)
|
Code looks great and the changes work correctly when tested in PR environment! Could you please resolve the interaction VRT TODOs in this PR? |
9941937 to
d862db1
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
tkajtoch
left a comment
There was a problem hiding this comment.
Looks good to me. Let's leave the interaction VRT TODOs for now
Summary
closes #7484
This PR adds more stories for components with the letter T:
Additionally adds base VRT reference images based on the added stories.
QA
Confirm that the prop controls for all the below stories provide relevant controls and that those controls work as expected:
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitoken--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitooltip--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euiicontip--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitour-euitour--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitour-euitourstep--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitour-euitourstepindicator--playground