Closed
Conversation
tkajtoch
commented
May 13, 2024
| echo "+++ Running visual regression tests on pull request #${BUILDKITE_PULL_REQUEST}" | ||
| echo "https://github.com/elastic/eui/pull/${BUILDKITE_PULL_REQUEST}" | ||
| storybook_url="https://eui.elastic.co/pr_${BUILDKITE_PULL_REQUEST}/storybook" | ||
| elif [[ "${BUILDKITE_BRANCH}" == "main" ]]; then |
Member
Author
There was a problem hiding this comment.
This is technically unused as of now, but will be in the release pipeline when this script is tested
c42807c to
34769f5
Compare
9 tasks
Member
Author
|
Will be unblocked and ready for review when https://github.com/elastic/ci-agent-images/pull/691 is merged |
1 task
|
Preview staging links for this PR:
|
Collaborator
💔 Build Failed
Failed CI StepsHistory
cc @tkajtoch |
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
|
❌ We're automatically closing this PR due to lack of activity. Please comment if you feel this was done in error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #7617.
This PR adds a new buildkite step to run Loki in CI for open pull requests.
QA
QA needs to be done manually after merging this PR. Please make sure the script and configuration look valid.