[Storybook] Add stories for more components (letter P) - Part 2#7674
[Storybook] Add stories for more components (letter P) - Part 2#7674mgadewoll merged 11 commits intoelastic:mainfrom
Conversation
dc4a923 to
ee3c402
Compare
- Fix `children` control - remove unnecessary `closeOnScroll` jsx prop (should inherit from `...rest` - disable `input` and `inputRef` props (not really possible to configure in controls)
…osition` + combo'd with `panelMinWidth` - requires moving the action toggles to just the playground, as an error will throw if `params.controls.include` is used with props that are not included
- requires moving the action toggles to just the playground, as an error will throw if `params.controls.include` is used with props that are not included
cee-chen
left a comment
There was a problem hiding this comment.
I pushed up some optional minor prop preferences and extra stories for my spacetime week in lieu of actually review, hope that's okay! Feel free to merge whenever!
There was a problem hiding this comment.
Awesome meta setup+use of decorators here! 🎉
There was a problem hiding this comment.
[not a change request, just a note for future me] I'd like to eventually add stories for container, insert, repositionOnScroll as well! I'm too lazy for now so I just added a quick story to demo how panelPaddingSize affects child titles & footers
|
|
||
| // NOTE: extended EuiPopoverProps are not resolved for some reason | ||
| // so we are currently manually adding them back | ||
| // TODO: remove this once types are properly resolved and added as control args |
There was a problem hiding this comment.
👍 Am personally good with these TODOs, EuiWrappingPopover is also generally kind of a weird component 😅 (also, I still need to look into button not being dynamically updatable...)
@cee-chen Thanks for the additional changes! They look good to me! 🎉 |
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
…tic#7674) Co-authored-by: Cee Chen <constance.chen@elastic.co>
Summary
closes #7481
This PR adds more stories for components with the letter P:
QA
Confirm that the prop controls for all the below stories provide relevant controls and that those controls work as expected:
https://eui.elastic.co/pr_7674/storybook/index.html?path=/story/layout-euiinputpopover--playground
https://eui.elastic.co/pr_7674/storybook/index.html?path=/story/layout-euipopover-euipopover--playground
https://eui.elastic.co/pr_7674/storybook/index.html?path=/story/layout-euipopover-euipopovertitle--playground
https://eui.elastic.co/pr_7674/storybook/index.html?path=/story/layout-euipopover-euipopoverfooter--playground
https://eui.elastic.co/pr_7674/storybook/index.html?path=/story/layout-euiwrappingpopover--playground
https://eui.elastic.co/pr_7674/storybook/index.html?path=/story/utilities-euiportal--playground
https://eui.elastic.co/pr_7674/storybook/index.html?path=/story/display-euiprogress--indeterminate
https://eui.elastic.co/pr_7674/storybook/index.html?path=/story/display-euiprogress--determinate