Skip to content

[EuiTable] Initial table styles setup#7622

Merged
cee-chen merged 5 commits intoelastic:tableflipfrom
cee-chen:emotion/table-2
Mar 26, 2024
Merged

[EuiTable] Initial table styles setup#7622
cee-chen merged 5 commits intoelastic:tableflipfrom
cee-chen:emotion/table-2

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Mar 26, 2024 •
edited
Loading

Summary

NOTE: This is going into the EuiTable Emotion conversion/cleanup feature branch.

Basic setup PR, nothing too fancy going on here (yet, see the fun TODO message ✨)

⚠️ Class name removals that may affect consumers (but no usages in Kibana):

  • .euiTable--auto
  • .euiTable--compressed

QA

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
      - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA - N/A
  • Release checklist - Skipping the Emotion changelog until the final feature branch, probably
  • Designer checklist - N/A

cee-chen added 5 commits March 25, 2024 17:08
@cee-chen
Set up EuiTable styles
7d0ac59
@cee-chen
Convert table layout styles + remove modifier class map
cd15e63
@cee-chen
Convert .euiTableCaption Sass
ef9c0b2
@cee-chen
Convert compressed vs uncompressed styles
323a436 
+ fix line-height regression from production - doesn't quite match the new `euiFontSize` util

- note: compressed styles are not applied in mobile views
@cee-chen
Snapshot updates
4af9a1a
@cee-chen cee-chen added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Mar 26, 2024
@cee-chen cee-chen changed the base branch from main to tableflip March 26, 2024 01:04
@cee-chen cee-chen marked this pull request as ready for review March 26, 2024 01:04
@cee-chen cee-chen requested a review from a team as a code owner March 26, 2024 01:04
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 26, 2024

Preview staging links for this PR:

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Mar 26, 2024

💚 Build Succeeded

mgadewoll
mgadewoll reviewed Mar 26, 2024
View reviewed changes
@cee-chen cee-chen merged commit 05cf6d8 into elastic:tableflip Mar 26, 2024
@cee-chen cee-chen deleted the emotion/table-2 branch March 26, 2024 17:27
cee-chen added a commit that referenced this pull request Mar 28, 2024
@cee-chen
[EuiTable] Initial table styles setup (#7622)
16b176c
cee-chen added a commit that referenced this pull request Apr 1, 2024
@cee-chen
[EuiTable] Initial table styles setup (#7622)
c05a4b7
cee-chen added a commit that referenced this pull request Apr 5, 2024
@cee-chen
[EuiTable] Initial table styles setup (#7622)
bd03fae
@cee-chen cee-chen mentioned this pull request Apr 5, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgadewoll mgadewoll mgadewoll approved these changes

Assignees

No one assigned

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cee-chen @kibanamachine @elasticmachine @mgadewoll