[EuiDataGrid] Fix "Grid row classes" docs example#7549
Merged
cee-chen merged 3 commits intoelastic:mainfrom Mar 5, 2024
Merged
[EuiDataGrid] Fix "Grid row classes" docs example#7549cee-chen merged 3 commits intoelastic:mainfrom
cee-chen merged 3 commits intoelastic:mainfrom
Conversation
…eserved `euiClasses` logic - instead, use an array of constants for the 2 data grid classes that we care about preserving so that consumers who don't name their custom classes coincidentally aren't also affected by this bug
- most noticeable on checkboxes
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
|
tkajtoch
approved these changes
Mar 5, 2024
Member
tkajtoch
left a comment
There was a problem hiding this comment.
Tested using the PR environment. Changes look and work great!
mgadewoll
approved these changes
Mar 5, 2024
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Mar 12, 2024
`v93.2.0`⏩`v93.3.0` --- ## [`v93.3.0`](https://github.com/elastic/eui/releases/v93.3.0) - Added new `EuiDataGrid` new prop: `cellContext`, an optional object of additional props passed to the cell render function. ([#7374](elastic/eui#7374)) - `EuiBreadcrumbs`'s `popoverContent` API now accepts a render function that will be passed a `closePopover` callback, allowing consumers to close the breadcrumb popover from their popover content ([#7555](elastic/eui#7555)) **Bug fixes** - Fixed missing animation on native `EuiProgress` bar update ([#7538](elastic/eui#7538)) - Fixed an `EuiDataGrid` bug with `gridStyle.rowClasses`, where custom consumer classes that began with `euiDataGridRow` would not be correctly removed/reapplied ([#7549](elastic/eui#7549)) - Fixed a visual `EuiDataGrid` bug where `EuiCheckbox`es within control columns were not vertically centered within single height rows ([#7549](elastic/eui#7549))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #7548 (fix is in first commit, other commits are bonus/cleanup)
This bug primarily affects our docs example, and likely has very minimal impact on consumers (given that it's unlikely that they're naming their own custom
classNames with.euiDataGridRow).QA
Reproducing the bug
QAing the fix
General checklist
- [ ] Checked in mobile- [ ] Checked for accessibility including keyboard-only and screenreader modes[ ] Added or updated jest and cypress testsOpted to skip this as the bug is so incredibly specific to our docs example, LMK if you disagree- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)